FreeCalypso > hg > fc-magnetite

view src/aci2/aci/cmh_mmi.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  CMH_MMI
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for the command handler
+----------------------------------------------------------------------------- 
*/ 

#ifndef CMH_MMI_H
#define CMH_MMI_H

/*==== CONSTANTS ==================================================*/
 
 
/*==== TYPES ======================================================*/

#ifdef ACI /* for for ATI only version */
typedef enum
{
  AUDIO_IN  =  75, /* audio in   */
  AUDIO_OUT = 175, /* audio out  */
  KEY_BEEP  = 100, /* key beep   */
  DTMF_TONE = 100, /* dtmf tone  */
  RINGER    = 100  /* ringer     */
}
T_VOLUME_TYPE;

typedef enum
{
  SWITCH_AUDIO_NONE,
  SWITCH_AUDIO_OFF,
  SWITCH_AUDIO_ALERT,
  SWITCH_AUDIO_BUSY,
  SWITCH_AUDIO_CALLWAIT
}
T_ACI_IBT_ACT;

typedef struct
{
  T_ACI_CPI_IBT ati_currIbt;
  T_ACI_CPI_TCH ati_currTch;
  T_ACI_IBT_ACT last_action;
} T_IBT_TYPE;

#endif

/*==== PROTOTYPES =================================================*/
GLOBAL void cmhMMI_keyIndication ( void );
GLOBAL void cmhMMI_rxIndication  ( void );
GLOBAL void cmhMMI_btIndication  ( void );

#ifdef ACI
GLOBAL void cmhMMI_setAudioVolume (  BYTE          audioIn, 
                                     BYTE          audioOut );

GLOBAL void cmhMMI_handleAudioTone ( T_ACI_AT_CMD  cmdId,
																		 UBYTE         response,
                                     T_ACI_CPI_MSG msgType );


/*==== EXPORT =====================================================*/

#ifdef CMH_MMIS_C
GLOBAL T_IBT_TYPE ibt_params;
#else
EXTERN T_IBT_TYPE ibt_params;
#endif

#endif /* ACI */

#endif /* CMH_MMI_H */

/*==== EOF =======================================================*/