FreeCalypso > hg > fc-magnetite
view src/aci2/aci/cmh_mmiq.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 93999a60b835 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-PS (6147) | Modul : CMH_MMIS +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This module provides the query functions related to the | protocol stack adapter for the man machine interface. +----------------------------------------------------------------------------- */ #ifndef CMH_MMIQ_C #define CMH_MMIQ_C #endif #include "aci_all.h" /*==== INCLUDES ===================================================*/ #include "aci_cmh.h" #include "psa_mmi.h" #include "cmh_mmi.h" #include "pcm.h" #ifdef UART #include "dti.h" #include "dti_conn_mng.h" #endif #ifdef FAX_AND_DATA #include "aci_fd.h" #endif /* of #ifdef FAX_AND_DATA */ #include "psa.h" #include "psa_sim.h" #include "cmh.h" #include "cmh_sim.h" #include "aoc.h" /*==== CONSTANTS ==================================================*/ /*==== EXPORT =====================================================*/ /*==== VARIABLES ==================================================*/ /*==== FUNCTIONS ==================================================*/ /* +--------------------------------------------------------------------+ | PROJECT : GSM-PS (6147) MODULE : CMH_MMIQ | | STATE : code ROUTINE : qAT_PlusCLAN | +--------------------------------------------------------------------+ PURPOSE : This is the functional counterpart to the +CLAN AT command which is responsible for query supporetd language code in ME. */ GLOBAL T_ACI_RETURN qAT_PlusCLAN ( T_ACI_CMD_SRC srcId, T_ACI_LAN_SUP* lngCode ) { CHAR* ef = EF_CLNG_ID; pcm_FileInfo_Type fileInfo; EF_CLNG lng; T_SIM_CMD_PRM * pSIMCmdPrm; /* points to SIM command parameters */ char *auptr="au"; TRACE_FUNCTION ("qAT_PlusCLAN()"); /* *------------------------------------------------------------------- * check command source *------------------------------------------------------------------- */ if(!cmh_IsVldCmdSrc (srcId)) { ACI_ERR_DESC( ACI_ERR_CLASS_Ext, EXT_ERR_Parameter ); return( AT_FAIL ); } pSIMCmdPrm = &cmhPrm[srcId].simCmdPrm; /* *------------------------------------------------------------------- * read supported language from ME *------------------------------------------------------------------- */ if (pcm_GetFileInfo ( ( UBYTE* ) ef, &fileInfo) NEQ PCM_OK) { ACI_ERR_DESC( ACI_ERR_CLASS_Cme, CME_ERR_Unknown ); return( AT_FAIL ); } else { if ( pcm_ReadFile ( (UBYTE*)ef, fileInfo.FileSize, (UBYTE*) &lng, &fileInfo.Version) EQ PCM_OK ) { memcpy(lngCode->str, &lng.data[0], 2); } else { ACI_ERR_DESC( ACI_ERR_CLASS_Cms, CMS_ERR_MemFail ); return( AT_FAIL ); } } /* *------------------------------------------------------------------- * Read EF ELP or LP from the sim if Automatic language is selected *------------------------------------------------------------------- */ if (!strcmp(lngCode->str, auptr)) { /* *------------------------------------------------------------- * check entity status *------------------------------------------------------------- */ if( simEntStat.curCmd NEQ AT_CMD_NONE ) return( AT_BUSY ); pSIMCmdPrm -> CLANact = CLAN_ACT_Read; /* *------------------------------------------------------------- * request EF ELP from SIM *------------------------------------------------------------- */ return cmhSIM_ReqLanguage ( srcId ); } return( AT_CMPL ); } /* +--------------------------------------------------------------------+ | PROJECT : GSM-PS (6147) MODULE : CMH_MMIQ | | STATE : code ROUTINE : qAT_PlusCLAE | +--------------------------------------------------------------------+ PURPOSE : This is the functional counterpart to the +CLAE? AT command which returns the current setting of mode . <mode>: Enable or Disable the unsolicited result code, when the language in the ME is changend. */ GLOBAL T_ACI_RETURN qAT_PlusCLAE (T_ACI_CMD_SRC srcId, T_ACI_CLAE_MOD *mode) { T_PHB_CMD_PRM * pPHBCmdPrm; /* points to PHB command parameter */ TRACE_FUNCTION ("qAT_PlusCLAE()"); /* *------------------------------------------------------------------- * check command source *------------------------------------------------------------------- */ if(!cmh_IsVldCmdSrc (srcId)) { ACI_ERR_DESC( ACI_ERR_CLASS_Ext, EXT_ERR_Parameter ); return( AT_FAIL ); } pPHBCmdPrm = &cmhPrm[srcId].phbCmdPrm; /* *------------------------------------------------------------------- * fill parameter mode *------------------------------------------------------------------- */ *mode= pPHBCmdPrm->CLAEmode; return( AT_CMPL ); } /* +-------------------------------------------------------------------+ | PROJECT : GSM-PS (6147) MODULE : CMH_MMIQ | | ROUTINE : qAT_PercentCUST | +-------------------------------------------------------------------+ PURPOSE : This function will set the customisation mode for the ACI and other required entities */ GLOBAL T_ACI_RETURN qAT_PercentCUST( T_ACI_CMD_SRC srcId, T_CUST_MOD *customisation_mode) { /* *------------------------------------------------------------------- * check command source *------------------------------------------------------------------- */ if(!cmh_IsVldCmdSrc (srcId)) { ACI_ERR_DESC( ACI_ERR_CLASS_Ext, EXT_ERR_Parameter ); return( AT_FAIL ); } *customisation_mode = simShrdPrm.setPrm[srcId].cust_mode; return (AT_CMPL); } /* +-------------------------------------------------------------------+ | PROJECT : GSM-PS (6147) MODULE : CMH_MMIQ | | ROUTINE : qAT_PercentSATCC | +-------------------------------------------------------------------+ PURPOSE : This function will query the Call Control mode from the ACI */ GLOBAL T_ACI_RETURN qAT_PercentSATCC( T_ACI_CMD_SRC srcId, T_SAT_CC_MOD *sat_cc_mode) { /* *------------------------------------------------------------------- * check command source *------------------------------------------------------------------- */ if(!cmh_IsVldCmdSrc (srcId)) { ACI_ERR_DESC( ACI_ERR_CLASS_Ext, EXT_ERR_Parameter ); return( AT_FAIL ); } *sat_cc_mode = simShrdPrm.setPrm[srcId].sat_cc_mode; return (AT_CMPL); } /*==== EOF ========================================================*/