view src/aci2/aci/cmh_snds.c @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+-----------------------------------------------------------------------------
|  Project :
|  Modul   :
+-----------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG
|                 All rights reserved.
|
|                 This file is confidential and a trade secret of Texas
|                 Instruments Berlin, AG
|                 The receipt of or possession of this file does not convey
|                 any rights to reproduce or disclose its contents or to
|                 manufacture, use, or sell anything it may describe, in
|                 whole, or in part, without the specific written consent of
|                 Texas Instruments Berlin, AG.
+-----------------------------------------------------------------------------
|  Purpose :  This module implements the set fuinctions related to the
|             protocol stack adapter for the SNDCP entity.
+-----------------------------------------------------------------------------
*/

#ifdef GPRS

#ifndef CMH_SNDS_C
#define CMH_SNDS_C
#endif

#include "aci_all.h"
/*==== INCLUDES ===================================================*/
#include "dti.h"      /* functionality of the dti library */
#include "dti_conn_mng.h"

#include "aci_cmh.h"

#include "cmh_snd.h"

#include "dti_cntrl_mng.h"

#include "gaci_cmh.h"
#include "gaci.h"
#include "psa.h"
#include "cmh.h"
#include "psa_sm.h"
#include "cmh_sm.h"

/*==== CONSTANTS ==================================================*/

/*==== EXPORT =====================================================*/

/*==== VARIABLES ==================================================*/

/*==== FUNCTIONS ==================================================*/
EXTERN void psaSN_CountReq ( UBYTE c_id, BOOL reset );


/*
+--------------------------------------------------------------------+
| PROJECT : GSM-PS (8441)         MODULE  : CMH_SMS                  |
| STATE   : finnished             ROUTINE : sAT_PercentSNCNT         |
+--------------------------------------------------------------------+

PURPOSE : This is the functional counterpart to the %SNCNT = AT
          command which resets the SNDCP Counter.
*/
GLOBAL T_ACI_RETURN sAT_PercentSNCNT( T_ACI_CMD_SRC srcId, BOOL reset_counter )
{
  UBYTE i;
  UBYTE sndcp_id;

  TRACE_FUNCTION ("sAT_PercentSNCNT()");

  sndcpShrdPrm.srcId = srcId;

  for (i = 0; i < MAX_CID ; i++)         /* Count req is sent for both activated and deactivated CID */
  {
    if ( (pdp_context[i].state EQ CS_DATA_LINK OR
        pdp_context[i].state EQ CS_ACTIVATED) OR (pdp_context[i].nsapi NEQ UNUSED_NSAPI AND 
        pdp_context[i].state EQ CS_DEFINED))
    {
      sndcp_id = pdp_context[i].nsapi;
      psaSN_CountReq( sndcp_id, reset_counter );

      TRACE_EVENT_P1("found SNDCP connection on channel %d", sndcp_id);
    }
  }

  return AT_CMPL;
}

#endif /* GPRS */