FreeCalypso > hg > fc-magnetite
view src/aci2/aci/dcm_handle_message.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 93999a60b835 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-F&D (8411) | Modul : ACI +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Description : DCM handle_msg function, which is called when DCM | receives a new message by application or rAT_function. +----------------------------------------------------------------------------- */ /*********************************** INCLUDES ********************************************/ #include "aci_all.h" #include "dcm.h" #include "dcm_utils.h" #include "dcm_state.h" #include "dcm_env.h" /**************************** LOCAL VARIABLE DEFINITION ***********************************/ /**************************** EXTERN VARIABLE DEFINITION **********************************/ extern T_DCM_ENV_CTRL_BLK *dcm_env_ctrl_blk_p; /**************************** LOCAL FUCNTION DEFINITION ***********************************/ /************************** EXTERN FUCNTION DEFINITION ************************************/ /****************************************************************************************** * Function : dcm_handle_message * Description : Called every time DCM is in WAITING state or * When receiving message from Application or rAT_function * Parameter : T_DCM_HDR * -Pointer on the header of the message. * Return : T_DCM_RET DCM * -DCM Result : DCM_OK, DCM_NOT_READY. * History : 0001 03/09/17 CJH Created ********************************************************************************************/ T_DCM_RET dcm_handle_message(T_DCM_HDR *msg_p) { T_DCM_GET_CURRENT_CONN_REQ_MSG *current_conn_info; TRACE_FUNCTION("DCM: dcm_handle_message()"); dcm_display_message(msg_p->msg_id); dcm_dispay_state((U8)dcm_env_ctrl_blk_p->state[0], (U8)dcm_env_ctrl_blk_p->substate[0]); if (msg_p != NULL) { /* get current conn req is always received regardless of current state..*/ if(msg_p->msg_id == DCM_GET_CURRENT_CONN_REQ_MSG) { TRACE_EVENT("DCM: DCM_GET_CURRENT_CONN_REQ_MSG"); current_conn_info = (T_DCM_GET_CURRENT_CONN_REQ_MSG*)msg_p; dcm_process_get_current_conn_event(current_conn_info); return DCM_OK; } switch (dcm_env_ctrl_blk_p->state[0]) { case DCM_IDLE: TRACE_EVENT("DCM: DCM_IDLE") ; /* there is no current action */ return dcm_idle(msg_p); case DCM_ACTIVATING_CONN: TRACE_EVENT("DCM: DCM_ACTIVATING_CONN") ; /* An IP User have asked the opening of a connection */ return dcm_activating_conn(msg_p); case DCM_CONN_ACTIVATED: TRACE_EVENT("DCM: DCM_CONN_ACTIVATED") ; /* At leat, on connection is active */ return dcm_conn_activated(msg_p); case DCM_CLOSING_CONN: TRACE_EVENT("DCM: DCM_CLOSING_CONN") ; /* An IP User have asked the closing of a connection */ return dcm_closing_conn(msg_p); default: TRACE_EVENT("DCM: unknown state") ; return DCM_NOT_READY; } } else { TRACE_ERROR("DCM: NULL message") ; return DCM_INVALID_PARAMETER; } }