FreeCalypso > hg > fc-magnetite

view src/aci2/aci/gaci_srcc.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  source control management for GACI.
+----------------------------------------------------------------------------- 
*/ 

#ifndef GACI_SRCC_H
#define GACI_SRCC_H


typedef enum {
  SRRC_SNDCP_ENTITY = 0,
  SRRC_PPPS_ENTITY,
  SRRC_SIM_ENTITY,
#ifdef CO_UDP_IP
  SRRC_IP_ENTITY,
#endif
#ifdef FF_GPF_TCPIP
  SRRC_TCPIP_ENTITY,
#endif /* FF_GPF_TCPIP */
  SRRC_MAX_ENTITY

} SRCC_ENTITY_ID;


typedef enum {
  SRCC_INVALID_LINK = -1,
  SRCC_PPPS_SNDCP_LINK,
  SRCC_NULL_SNDCP_LINK,
  SRCC_SIM_SNDCP_LINK,
#if defined (FF_PKTIO) OR defined (FF_TCP_IP) OR defined(FF_GPF_TCPIP) OR defined(FF_PSI)
  SRCC_PKTIO_SNDCP_LINK,
#endif /* FF_PKTIO OR FF_TCP_IP OR FF_GPF_TCPIP OR FF_PSI */
#if defined(FF_GPF_TCPIP)
  SRCC_TCPIP_SNDCP_LINK,
#endif /* FF_GPF_TCPIP */
  SRCC_IP_SNDCP_LINK,
  SRCC_MAX_LINK

} SRCC_LINK_NO;


/*********************************************************************/
/** START ** This will be defined in the SAP of the entity ** START **/

#ifndef MAX_SNDCP_INSTANCES
  #define MAX_SNDCP_INSTANCES  11
#endif

#ifndef MAX_PPPS_INSTANCES
  #define MAX_PPPS_INSTANCES  1
#endif

#ifndef MAX_SIM_INSTANCES
  #define MAX_SIM_INSTANCES  1
#endif

/************ WAP ************/
#ifdef CO_UDP_IP 
#ifndef MAX_IP_INSTANCES
  #define MAX_IP_INSTANCES  1
#endif
#endif
#ifdef FF_GPF_TCPIP
#ifndef MAX_TCPIP_INSTANCES
  #define MAX_TCPIP_INSTANCES 1
#endif
#endif
/************ WAP ************/
/*** END *** This will be defined in the SAP of the entity *** END ***/
/*********************************************************************/





/*
 *    function declarations
 */
EXTERN void   srcc_init             ( void );
EXTERN void   srcc_new_count        ( SRCC_LINK_NO link_no );
EXTERN void   srcc_delete_count     ( SRCC_LINK_NO link_no );
EXTERN BOOL   srcc_reserve_sources  ( SRCC_LINK_NO link_no, SHORT no );

#endif