FreeCalypso > hg > fc-magnetite
view src/aci2/aci/line_edit_intern.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 93999a60b835 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : | Modul : line edit +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This modul ... +----------------------------------------------------------------------------- */ #ifndef LINE_EDIT_INTERN_H #define LINE_EDIT_INTERN_H #define WS 0x20 #define SLASH '/' typedef struct S_LEDIT_ATCMD_M { T_LEDIT_ATCMD *cmd; struct S_LEDIT_ATCMD_M *next; } T_LEDIT_ATCMD_M; typedef struct S_LEDIT_INTERN { UBYTE src_id; USHORT len; BOOL isStr; /* flag for start and end of "....." */ USHORT copyIter; /* copy iterator from src to cmd buffer */ USHORT srcBufIter; /* iterator over the srcBuffer */ USHORT srcBufIterE; /* from here all chars to echo */ const UBYTE *srcBuffer; char *lineBuffer; /* cmds without "AT" and removed WS,BS,... */ USHORT lineBufIter; char *origBuffer; /* cmds without "AT", removed WS,BS,... - NOT converted to upper case */ USHORT origBufIter; char *execBuffer; /* the current command(s) as well as */ USHORT execBufIter; /* for AT/ the copy of the last cmd line */ char *smsBuffer; /* text of a SMS */ BOOL txtChunk; /* received a chunk of text only */ T_LEDIT_ATCMD_M *cmdm; /* */ UBYTE cmdIndex; /* */ UBYTE cmdGetIter; /* needed in ledit_get_next() */ T_LEDIT_RSLT (*state) (struct S_LEDIT_INTERN *atiInt); /* state machine function pointer */ T_LEDIT lineHabit; /* the behaviour of the line */ T_LEDIT_ERR err; } T_LEDIT_INTERN; typedef struct S_LEDIT_SRC_MAINTAIN { T_LEDIT_INTERN *leditInt; struct S_LEDIT_SRC_MAINTAIN *next; } T_LEDIT_SRC_MAINTAIN; /* moved from line_edit.h to avoid multiple memory allocation in different modules */ static const T_LEDIT_ERR ledit_err[] = { {"out of memory", LEDIT_ERR_NoMemory}, {"no maintenance for src_id", LEDIT_ERR_NoMaintenance}, {"no valid command", LEDIT_ERR_NoValidCommand}, {"last cmd line is pending", LEDIT_ERR_LastCmdPending}, {"unkown error", LEDIT_ERR_Unknown} }; #endif