FreeCalypso > hg > fc-magnetite
view src/aci2/aci/psa_gmms.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 93999a60b835 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This module defines the signalling functions of the | protocol stack adapter for the registration part of | GPRS mobility management ( GMM ). +----------------------------------------------------------------------------- */ #ifdef GPRS #ifndef PSA_GMMS_C #define PSA_GMMS_C #endif #include "aci_all.h" /*==== INCLUDES ===================================================*/ #include "aci_cmh.h" #include "ati_cmd.h" #include "aci_cmd.h" #include "gaci_cmh.h" #include "aci.h" #include "psa.h" #include "psa_gmm.h" /*==== CONSTANTS ==================================================*/ /*==== TYPES ======================================================*/ /*==== EXPORT =====================================================*/ /*==== VARIABLES ==================================================*/ /*==== FUNCTIONS ==================================================*/ /* +-------------------------------------------------------------------+ | PROJECT : GPRS (8441) MODULE : PSA_GMMS | | ROUTINE : psaGMM_Attach | +-------------------------------------------------------------------+ PURPOSE : start an attach */ GLOBAL void psaGMM_Attach ( UBYTE mobile_class, UBYTE attach_type, UBYTE service_mode ) { TRACE_FUNCTION ("psaGMM_Attach()"); GMM_PRIM_TRACE_2("ATT_REQ", dbg_mobileClass(mobile_class), dbg_attachType(attach_type)); /* *------------------------------------------------------------------- * create and send primitive for network attach *------------------------------------------------------------------- */ { PALLOC (gmmreg_attach_req, GMMREG_ATTACH_REQ); /* fill in primitive parameter: registration mode */ gmmreg_attach_req -> mobile_class = mobile_class; gmmreg_attach_req -> attach_type = attach_type; gmmreg_attach_req -> service_mode = service_mode; psaGMM_NetworkRegistrationStatus(GMMREG_ATTACH_REQ, gmmreg_attach_req); PSEND (hCommGMM, gmmreg_attach_req); } } /* +-------------------------------------------------------------------+ | PROJECT : GPRS (8441) MODULE : PSA_GMMS | | ROUTINE : psaGMM_Detach | +-------------------------------------------------------------------+ PURPOSE : start an detach */ GLOBAL void psaGMM_Detach ( UBYTE detach_type ) { TRACE_FUNCTION ("psaGMM_Detach()"); GMM_PRIM_TRACE_1("DET_REQ", dbg_detachType(detach_type)); /* *------------------------------------------------------------------- * create and send primitive for network attach *------------------------------------------------------------------- */ { PALLOC (gmmreg_detach_req, GMMREG_DETACH_REQ); /* fill in primitive parameter: registration mode */ gmmreg_detach_req -> detach_type = detach_type; PSEND (hCommGMM, gmmreg_detach_req); } } /* +-------------------------------------------------------------------+ | PROJECT : GPRS (8441) MODULE : PSA_GMMS | | ROUTINE : psaGMM_Net_Req | +-------------------------------------------------------------------+ PURPOSE : start a network search */ GLOBAL void psaGMM_Net_Req ( void ) { TRACE_FUNCTION ("psaGMM_Net_Req()"); /* *------------------------------------------------------------------- * create and send primitive for network attach *------------------------------------------------------------------- */ { PALLOC (gmmreg_net_req, GMMREG_NET_REQ); PSEND (hCommGMM, gmmreg_net_req); } } /* +-------------------------------------------------------------------+ | PROJECT : GPRS (8441) MODULE : PSA_GMMS | | ROUTINE : psaGMM_Plmn_res | +-------------------------------------------------------------------+ PURPOSE : select a PLMN after network search */ GLOBAL void psaGMM_Plmn_res ( UBYTE mobile_class, UBYTE attach_type, T_plmn *plmn ) { TRACE_FUNCTION ("psaGMM_Plmn_res()"); GMM_PRIM_TRACE_2("PLMN_RES", dbg_mobileClass(mobile_class), dbg_attachType(attach_type)); /* *------------------------------------------------------------------- * create and send primitive for network attach *------------------------------------------------------------------- */ { PALLOC (gmmreg_plmn_res, GMMREG_PLMN_RES); /* fill in primitive parameter: registration mode */ gmmreg_plmn_res -> plmn = *plmn; gmmreg_plmn_res -> attach_type = attach_type; gmmreg_plmn_res -> mobile_class = mobile_class; PSEND (hCommGMM, gmmreg_plmn_res); } } /* +-------------------------------------------------------------------+ | PROJECT : GPRS (8441) MODULE : PSA_GMMS | | ROUTINE : psaGMM_Plmn_mode_req | +-------------------------------------------------------------------+ PURPOSE : switch between automatic and manual mode of registration */ GLOBAL void psaGMM_Plmn_mode_req ( UBYTE net_selection_mode ) { TRACE_FUNCTION ("psaGMM_Plmn_mode_req()"); /* *------------------------------------------------------------------- * create and send primitive for network attach *------------------------------------------------------------------- */ { PALLOC (gmmreg_plmn_mode_req, GMMREG_PLMN_MODE_REQ); /* fill in primitive parameter: registration mode */ gmmreg_plmn_mode_req -> net_selection_mode = net_selection_mode; PSEND (hCommGMM, gmmreg_plmn_mode_req); } } /* +-------------------------------------------------------------------+ | PROJECT : GPRS (8441) MODULE : PSA_GMMS | | ROUTINE : psaGMM_Config_req | +-------------------------------------------------------------------+ PURPOSE : send a config request to GMM. */ GLOBAL void psaGMM_Config_req( UBYTE cipher_on, UBYTE tlli_handling ) { TRACE_FUNCTION ("psaGMM_Config_req()"); { PALLOC (gmmreg_config_req, GMMREG_CONFIG_REQ); gmmreg_config_req -> cipher_on = cipher_on; gmmreg_config_req -> tlli_handling = tlli_handling; PSEND (hCommGMM, gmmreg_config_req); } } #endif /* GPRS */ /*==== EOF ========================================================*/