FreeCalypso > hg > fc-magnetite

view src/aci2/aci/psa_smss.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  PSA_SMSS
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This module defines the signalling functions of the 
|             protocol stack adapter for the short message service SMS.
+----------------------------------------------------------------------------- 
*/ 

#ifndef PSA_SMSS_C
#define PSA_SMSS_C
#endif

#include "aci_all.h"

/*==== INCLUDES ===================================================*/
#include "aci_cmh.h"
#include "ati_cmd.h"
#include "aci_cmd.h"
#include "aci.h"
#include "psa.h"
#include "psa_sms.h"
#include "cmh_sms.h"
/*==== CONSTANTS ==================================================*/

/*==== TYPES ======================================================*/


/*==== EXPORT =====================================================*/


/*==== VARIABLES ==================================================*/

/*==== FUNCTIONS ==================================================*/

GLOBAL SHORT psaSMS_ReadReq ( UBYTE mem_type,  USHORT rec_num, 
                              UBYTE read_mode, T_ACI_SMS_STAT cmh_state )
{
  UBYTE psa_state;

  TRACE_FUNCTION ("psaSMS_ReadReq()");

  /*
   *-------------------------------------------------------------------
   * create and send primitive for SMS read
   *-------------------------------------------------------------------
   */
  {
    PALLOC (mnsms_read_req, MNSMS_READ_REQ);

    mnsms_read_req -> mem_type  = mem_type;
    mnsms_read_req -> rec_num   = (UBYTE)rec_num;
    mnsms_read_req -> read_mode = read_mode;
    if (cmhSMS_getStatPsa(cmh_state, &psa_state))
      mnsms_read_req -> status = psa_state;
    else
      mnsms_read_req -> status = NOT_PRESENT_8BIT;
      
    PSENDX (SMS, mnsms_read_req);
  }

  return 0;
}

/*
+-------------------------------------------------------------------+
| PROJECT : GSM-PS (6147)    MODULE  : PSA_SMSS                     |
|                            ROUTINE : psaSMS_PauseReq              |
+-------------------------------------------------------------------+

  ACI-ENH-19450: Added for %CPRMS command (MDF-07.04.2004)
  
  PURPOSE : build and send MNSMS_PAUSE_REQ to SMS

*/

GLOBAL void psaSMS_PauseReq ( )
{

  TRACE_FUNCTION ("psaSMS_PauseReq()");

  /* build and send MNSMS_PAUSE_REQ */
  {
    PALLOC (mnsms_pause_req, MNSMS_PAUSE_REQ);      
    PSENDX (SMS, mnsms_pause_req);
  }
  
}

/*
+-------------------------------------------------------------------+
| PROJECT : GSM-PS (6147)    MODULE  : PSA_SMSS                     |
|                            ROUTINE : psaSMS_ResumeReq             |
+-------------------------------------------------------------------+

  ACI-ENH-19450: Added for %CPRMS command (MDF-07.04.2004)
  
  PURPOSE : build and send MNSMS_RESUME_REQ to SMS

*/

GLOBAL void psaSMS_ResumeReq ( )
{

  TRACE_FUNCTION ("psaSMS_ResumeReq()");

  /* build and send MNSMS_PAUSE_REQ */
  {
    PALLOC (mnsms_resume_req, MNSMS_RESUME_REQ);      
    PSENDX (SMS, mnsms_resume_req);
  }
  
}

/*
+-------------------------------------------------------------------+
| PROJECT : GSM-PS (6147)    MODULE  : PSA_SMSS                     |
|                            ROUTINE : psaSMS_TestReq             |
+-------------------------------------------------------------------+

  ACI-ENH-19450: Added for %CPRMS command (MDF-07.04.2004)
  
  PURPOSE : build and send MNSMS_RESUME_REQ to SMS

*/

GLOBAL void psaSMS_QueryReq (UBYTE query_type)
{

  TRACE_FUNCTION ("psaSMS_QueryReq()");

  /* build and send MNSMS_QUERY_REQ */
  {
    PALLOC (mnsms_query_req, MNSMS_QUERY_REQ);

    mnsms_query_req->query_type = query_type; 
    
    PSENDX (SMS, mnsms_query_req);
  }
  
}


/*==== EOF ========================================================*/