FreeCalypso > hg > fc-magnetite
view src/aci2/alr/alr_test/alr_test.mak @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 93999a60b835 |
children |
line wrap: on
line source
# Microsoft Developer Studio Generated NMAKE File, Based on alr_test.dsp !IF "$(CFG)" == "" CFG=alr_test - Win32 Debug GSM !MESSAGE No configuration specified. Defaulting to alr_test - Win32 Debug GSM. !ENDIF !IF "$(CFG)" != "alr_test - Win32 Debug GPRS" && "$(CFG)" != "alr_test - Win32 Debug GSM" !MESSAGE Invalid configuration "$(CFG)" specified. !MESSAGE You can specify a configuration when running NMAKE !MESSAGE by defining the macro CFG on the command line. For example: !MESSAGE !MESSAGE NMAKE /f "alr_test.mak" CFG="alr_test - Win32 Debug GSM" !MESSAGE !MESSAGE Possible choices for configuration are: !MESSAGE !MESSAGE "alr_test - Win32 Debug GPRS" (based on "Win32 (x86) Dynamic-Link Library") !MESSAGE "alr_test - Win32 Debug GSM" (based on "Win32 (x86) Dynamic-Link Library") !MESSAGE !ERROR An invalid configuration is specified. !ENDIF !IF "$(OS)" == "Windows_NT" NULL= !ELSE NULL=nul !ENDIF !IF "$(CFG)" == "alr_test - Win32 Debug GPRS" OUTDIR=.\GPRS INTDIR=.\GPRS # Begin Custom Macros OutDir=.\GPRS # End Custom Macros ALL : "..\..\..\test\alr_gprs_test\alr_gprs.dll" "$(OUTDIR)\alr_test.bsc" CLEAN : -@erase "$(INTDIR)\alr_cases.obj" -@erase "$(INTDIR)\alr_cases.sbr" -@erase "$(INTDIR)\alr_cbch_constraints.obj" -@erase "$(INTDIR)\alr_cbch_constraints.sbr" -@erase "$(INTDIR)\alr_cbch_steps.obj" -@erase "$(INTDIR)\alr_cbch_steps.sbr" -@erase "$(INTDIR)\alr_constraints.obj" -@erase "$(INTDIR)\alr_constraints.sbr" -@erase "$(INTDIR)\alr_dedicated_constraints.obj" -@erase "$(INTDIR)\alr_dedicated_constraints.sbr" -@erase "$(INTDIR)\alr_dedicated_steps.obj" -@erase "$(INTDIR)\alr_dedicated_steps.sbr" -@erase "$(INTDIR)\alr_idle_constraints.obj" -@erase "$(INTDIR)\alr_idle_constraints.sbr" -@erase "$(INTDIR)\alr_idle_steps.obj" -@erase "$(INTDIR)\alr_idle_steps.sbr" -@erase "$(INTDIR)\alr_ncell_constraints.obj" -@erase "$(INTDIR)\alr_ncell_constraints.sbr" -@erase "$(INTDIR)\alr_ncell_steps.obj" -@erase "$(INTDIR)\alr_ncell_steps.sbr" -@erase "$(INTDIR)\alr_steps.obj" -@erase "$(INTDIR)\alr_steps.sbr" -@erase "$(INTDIR)\vc60.idb" -@erase "$(INTDIR)\vc60.pdb" -@erase "$(OUTDIR)\alr_gprs.exp" -@erase "$(OUTDIR)\alr_gprs.lib" -@erase "$(OUTDIR)\alr_gprs.map" -@erase "$(OUTDIR)\alr_test.bsc" -@erase "..\..\..\test\alr_gprs_test\alr_gprs.dll" "$(OUTDIR)" : if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)" CPP=cl.exe CPP_PROJ=/nologo /Zp1 /MDd /W3 /Zi /Od /I "\gpf\inc" /I "\gpf\tap" /I "\g23m\condat\ms\tdcinc" /D "USE_DLL" /D "_WINDOWS" /D "WIN32" /D "USE_TCD_STUB" /D "GPRS" /Fr"$(INTDIR)\\" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\\" /FD /GZ /GZ /Zm1000 /c .c{$(INTDIR)}.obj:: $(CPP) @<< $(CPP_PROJ) $< << .cpp{$(INTDIR)}.obj:: $(CPP) @<< $(CPP_PROJ) $< << .cxx{$(INTDIR)}.obj:: $(CPP) @<< $(CPP_PROJ) $< << .c{$(INTDIR)}.sbr:: $(CPP) @<< $(CPP_PROJ) $< << .cpp{$(INTDIR)}.sbr:: $(CPP) @<< $(CPP_PROJ) $< << .cxx{$(INTDIR)}.sbr:: $(CPP) @<< $(CPP_PROJ) $< << MTL=midl.exe MTL_PROJ=/nologo /D "_DEBUG" /mktyplib203 /win32 RSC=rc.exe BSC32=bscmake.exe BSC32_FLAGS=/nologo /o"$(OUTDIR)\alr_test.bsc" BSC32_SBRS= \ "$(INTDIR)\alr_cases.sbr" \ "$(INTDIR)\alr_constraints.sbr" \ "$(INTDIR)\alr_steps.sbr" \ "$(INTDIR)\alr_dedicated_constraints.sbr" \ "$(INTDIR)\alr_dedicated_steps.sbr" \ "$(INTDIR)\alr_ncell_constraints.sbr" \ "$(INTDIR)\alr_ncell_steps.sbr" \ "$(INTDIR)\alr_cbch_constraints.sbr" \ "$(INTDIR)\alr_cbch_steps.sbr" \ "$(INTDIR)\alr_idle_constraints.sbr" \ "$(INTDIR)\alr_idle_steps.sbr" "$(OUTDIR)\alr_test.bsc" : "$(OUTDIR)" $(BSC32_SBRS) $(BSC32) @<< $(BSC32_FLAGS) $(BSC32_SBRS) << LINK32=link.exe LINK32_FLAGS=kernel32.lib user32.lib gdi32.lib shell32.lib wsock32.lib /nologo /subsystem:windows /dll /pdb:none /map:"$(INTDIR)\alr_gprs.map" /debug /machine:IX86 /nodefaultlib:"LIBCD" /nodefaultlib:"LIBC" /out:"\g23m\condat\ms\test\alr_gprs_test\alr_gprs.dll" /implib:"$(OUTDIR)\alr_gprs.lib" /FORCE:MULTIPLE LINK32_OBJS= \ "$(INTDIR)\alr_cases.obj" \ "$(INTDIR)\alr_constraints.obj" \ "$(INTDIR)\alr_steps.obj" \ "$(INTDIR)\alr_dedicated_constraints.obj" \ "$(INTDIR)\alr_dedicated_steps.obj" \ "$(INTDIR)\alr_ncell_constraints.obj" \ "$(INTDIR)\alr_ncell_steps.obj" \ "$(INTDIR)\alr_cbch_constraints.obj" \ "$(INTDIR)\alr_cbch_steps.obj" \ "$(INTDIR)\alr_idle_constraints.obj" \ "$(INTDIR)\alr_idle_steps.obj" \ "..\..\..\tdclib\tdcinc.lib" \ "..\..\..\..\..\..\GPF\LIB\win32\tdc.lib" "..\..\..\test\alr_gprs_test\alr_gprs.dll" : "$(OUTDIR)" $(DEF_FILE) $(LINK32_OBJS) $(LINK32) @<< $(LINK32_FLAGS) $(LINK32_OBJS) << !ELSEIF "$(CFG)" == "alr_test - Win32 Debug GSM" OUTDIR=.\GSM INTDIR=.\GSM # Begin Custom Macros OutDir=.\GSM # End Custom Macros ALL : "..\..\..\test\alr_gsm_test\alr_gsm.dll" "$(OUTDIR)\alr_test.bsc" CLEAN : -@erase "$(INTDIR)\alr_cases.obj" -@erase "$(INTDIR)\alr_cases.sbr" -@erase "$(INTDIR)\alr_cbch_constraints.obj" -@erase "$(INTDIR)\alr_cbch_constraints.sbr" -@erase "$(INTDIR)\alr_cbch_steps.obj" -@erase "$(INTDIR)\alr_cbch_steps.sbr" -@erase "$(INTDIR)\alr_constraints.obj" -@erase "$(INTDIR)\alr_constraints.sbr" -@erase "$(INTDIR)\alr_dedicated_constraints.obj" -@erase "$(INTDIR)\alr_dedicated_constraints.sbr" -@erase "$(INTDIR)\alr_dedicated_steps.obj" -@erase "$(INTDIR)\alr_dedicated_steps.sbr" -@erase "$(INTDIR)\alr_idle_constraints.obj" -@erase "$(INTDIR)\alr_idle_constraints.sbr" -@erase "$(INTDIR)\alr_idle_steps.obj" -@erase "$(INTDIR)\alr_idle_steps.sbr" -@erase "$(INTDIR)\alr_ncell_constraints.obj" -@erase "$(INTDIR)\alr_ncell_constraints.sbr" -@erase "$(INTDIR)\alr_ncell_steps.obj" -@erase "$(INTDIR)\alr_ncell_steps.sbr" -@erase "$(INTDIR)\alr_steps.obj" -@erase "$(INTDIR)\alr_steps.sbr" -@erase "$(INTDIR)\vc60.idb" -@erase "$(INTDIR)\vc60.pdb" -@erase "$(OUTDIR)\alr_gsm.exp" -@erase "$(OUTDIR)\alr_gsm.lib" -@erase "$(OUTDIR)\alr_gsm.map" -@erase "$(OUTDIR)\alr_test.bsc" -@erase "..\..\..\test\alr_gsm_test\alr_gsm.dll" "$(OUTDIR)" : if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)" CPP=cl.exe CPP_PROJ=/nologo /Zp1 /MDd /W3 /Zi /Od /I "\gpf\inc" /I "\gpf\tap" /I "\g23m\condat\ms\tdcinc" /D "USE_DLL" /D "_WINDOWS" /D "WIN32" /D "USE_TCD_STUB" /Fr"$(INTDIR)\\" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\\" /FD /GZ /GZ /Zm1000 /c .c{$(INTDIR)}.obj:: $(CPP) @<< $(CPP_PROJ) $< << .cpp{$(INTDIR)}.obj:: $(CPP) @<< $(CPP_PROJ) $< << .cxx{$(INTDIR)}.obj:: $(CPP) @<< $(CPP_PROJ) $< << .c{$(INTDIR)}.sbr:: $(CPP) @<< $(CPP_PROJ) $< << .cpp{$(INTDIR)}.sbr:: $(CPP) @<< $(CPP_PROJ) $< << .cxx{$(INTDIR)}.sbr:: $(CPP) @<< $(CPP_PROJ) $< << MTL=midl.exe MTL_PROJ=/nologo /D "_DEBUG" /mktyplib203 /win32 RSC=rc.exe BSC32=bscmake.exe BSC32_FLAGS=/nologo /o"$(OUTDIR)\alr_test.bsc" BSC32_SBRS= \ "$(INTDIR)\alr_cases.sbr" \ "$(INTDIR)\alr_constraints.sbr" \ "$(INTDIR)\alr_steps.sbr" \ "$(INTDIR)\alr_dedicated_constraints.sbr" \ "$(INTDIR)\alr_dedicated_steps.sbr" \ "$(INTDIR)\alr_ncell_constraints.sbr" \ "$(INTDIR)\alr_ncell_steps.sbr" \ "$(INTDIR)\alr_cbch_constraints.sbr" \ "$(INTDIR)\alr_cbch_steps.sbr" \ "$(INTDIR)\alr_idle_constraints.sbr" \ "$(INTDIR)\alr_idle_steps.sbr" "$(OUTDIR)\alr_test.bsc" : "$(OUTDIR)" $(BSC32_SBRS) $(BSC32) @<< $(BSC32_FLAGS) $(BSC32_SBRS) << LINK32=link.exe LINK32_FLAGS=kernel32.lib user32.lib gdi32.lib shell32.lib wsock32.lib /nologo /subsystem:windows /dll /pdb:none /map:"$(INTDIR)\alr_gsm.map" /debug /machine:IX86 /nodefaultlib:"LIBCD" /nodefaultlib:"LIBC" /out:"\g23m\condat\ms\test\alr_gsm_test\alr_gsm.dll" /implib:"$(OUTDIR)\alr_gsm.lib" /FORCE:MULTIPLE LINK32_OBJS= \ "$(INTDIR)\alr_cases.obj" \ "$(INTDIR)\alr_constraints.obj" \ "$(INTDIR)\alr_steps.obj" \ "$(INTDIR)\alr_dedicated_constraints.obj" \ "$(INTDIR)\alr_dedicated_steps.obj" \ "$(INTDIR)\alr_ncell_constraints.obj" \ "$(INTDIR)\alr_ncell_steps.obj" \ "$(INTDIR)\alr_cbch_constraints.obj" \ "$(INTDIR)\alr_cbch_steps.obj" \ "$(INTDIR)\alr_idle_constraints.obj" \ "$(INTDIR)\alr_idle_steps.obj" \ "..\..\..\tdclib\tdcinc.lib" \ "..\..\..\..\..\..\GPF\LIB\win32\tdc.lib" "..\..\..\test\alr_gsm_test\alr_gsm.dll" : "$(OUTDIR)" $(DEF_FILE) $(LINK32_OBJS) $(LINK32) @<< $(LINK32_FLAGS) $(LINK32_OBJS) << !ENDIF !IF "$(NO_EXTERNAL_DEPS)" != "1" !IF EXISTS("alr_test.dep") !INCLUDE "alr_test.dep" !ELSE !MESSAGE Warning: cannot find "alr_test.dep" !ENDIF !ENDIF !IF "$(CFG)" == "alr_test - Win32 Debug GPRS" || "$(CFG)" == "alr_test - Win32 Debug GSM" SOURCE=.\alr_cases.cpp "$(INTDIR)\alr_cases.obj" "$(INTDIR)\alr_cases.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_constraints.cpp "$(INTDIR)\alr_constraints.obj" "$(INTDIR)\alr_constraints.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_steps.cpp "$(INTDIR)\alr_steps.obj" "$(INTDIR)\alr_steps.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_dedicated_constraints.cpp "$(INTDIR)\alr_dedicated_constraints.obj" "$(INTDIR)\alr_dedicated_constraints.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_dedicated_steps.cpp "$(INTDIR)\alr_dedicated_steps.obj" "$(INTDIR)\alr_dedicated_steps.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_ncell_constraints.cpp "$(INTDIR)\alr_ncell_constraints.obj" "$(INTDIR)\alr_ncell_constraints.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_ncell_steps.cpp "$(INTDIR)\alr_ncell_steps.obj" "$(INTDIR)\alr_ncell_steps.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_cbch_constraints.cpp "$(INTDIR)\alr_cbch_constraints.obj" "$(INTDIR)\alr_cbch_constraints.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_cbch_steps.cpp "$(INTDIR)\alr_cbch_steps.obj" "$(INTDIR)\alr_cbch_steps.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_idle_constraints.cpp "$(INTDIR)\alr_idle_constraints.obj" "$(INTDIR)\alr_idle_constraints.sbr" : $(SOURCE) "$(INTDIR)" SOURCE=.\alr_idle_steps.cpp "$(INTDIR)\alr_idle_steps.obj" "$(INTDIR)\alr_idle_steps.sbr" : $(SOURCE) "$(INTDIR)" !ENDIF