src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

#ifndef AUITEXTENTRY_H
#define AUITEXTENTRY_H

/* Key entry information*/
	
typedef struct
{
	T_MFW_HND			win;				/* The editor window */
	U32					update;				/* Event to be sent to the window to update it */
	T_ED_DATA			*editor;			/* Pointer to editor data */
	UBYTE				Level;            	/* Alpha level selected     */
	UBYTE				Key;                /* Alpha mode current key   */
	T_MFW_HND			editTim;			/* The timer for multi-tap */
}
T_AUI_ENTRY_DATA;


T_AUI_ENTRY_DATA 	*AUI_entry_Create(T_MFW_HND win, T_ED_DATA *editor, U32 update);
void 				AUI_entry_Destroy(T_AUI_ENTRY_DATA *entry_data);
USHORT 				AUI_entry_EditChar (T_AUI_ENTRY_DATA *entry_data, USHORT alphachar, BOOL multitap);
USHORT				AUI_entry_EditDigit (T_AUI_ENTRY_DATA *entry_data, UBYTE code);
USHORT				AUI_entry_EventKey (T_AUI_ENTRY_DATA *entry_data, MfwEvt event, MfwKbd *key);
USHORT				AUI_entry_GetKeyChar(T_AUI_ENTRY_DATA *entry_data, T_ED_CASE_PREF casePref);
void 				AUI_entry_StopMultitap(T_AUI_ENTRY_DATA *entry_data);
#endif