FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiAoc.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _MMIAOC_H_ #define _MMIAOC_H_ 1 /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: Advice of Charge $File: MmiAoc.h $Revision: 1.0 $Author: Condat(UK) $Date: 25/10/00 ******************************************************************************** Description: This provides the start code for the MMI ******************************************************************************** $History: MmiAoc.h 25/10/00 Original Condat(UK) BMI version. $End *******************************************************************************/ /******************************************************************************* Include files *******************************************************************************/ /******************************************************************************* Interface constants *******************************************************************************/ /******************************************************************************* Public methods *******************************************************************************/ int aoc_credit_remaining (MfwMnu* m, MfwMnuItem* i); int aoc_charge_rate (MfwMnu* m, MfwMnuItem* i); int aoc_view_limit (MfwMnu* m, MfwMnuItem* i); int aoc_change_limit (MfwMnu* m, MfwMnuItem* i); int aoc_cancel_limit (MfwMnu* m, MfwMnuItem* i); int aoc_last_charge (MfwMnu* m, MfwMnuItem* i); int aoc_total_charge (MfwMnu* m, MfwMnuItem* i); int aoc_reset_charge (MfwMnu* m, MfwMnuItem* i); USHORT service_check_aoc (struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, struct MfwMnuItemTag *mi); EXTERN LONG acm_last_call; //accumulated call meter from the last call /******************************************************************************* End of File *******************************************************************************/ #endif