FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiBlkManager.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _MMI_BLKMANAGER_H_ #define _MMI_BLKMANAGER_H_ /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: PhoneBook $File: MmiBlkManager.h $Revision: 1.0 $Author: Condat(UK) $Date: 25/10/00 ******************************************************************************** Description: The block manager is responsible for creating and initialising the structures and tables to allow access to the strings, icons sounds and vibrations required by the MMI. Each of these items is effectively a contiguous block of memory, which is accessed via a block resource. Each of the block resources are provided by this package ******************************************************************************** $History: MmiBlkManager.h 25/10/00 Original Condat(UK) BMI version. $End *******************************************************************************/ #include "MmiBlkResources.h" /* Define the block resources we are dealing with, for now just identify the sounds icons and vibrations, and fill the rest with languages. We don't actually care what these are for now, they're just placeholders */ #define ALLOC_MEMORY mfwAlloc #define FREE_MEMORY mfwFree #define MMI_LANG_0 0 #define MMI_LANG_1 1 #define MMI_LANG_2 2 #define MMI_LANG_3 3 #define MMI_LANG_4 4 #define MMI_LANG_5 5 #define MMI_LANG_6 6 #define MMI_LANG_7 7 #define MMI_LANG_8 8 #define MMI_LANG_9 9 #define MMI_LANG_10 10 #define MMI_LANG_11 11 #define MMI_LANG_12 12 #define MMI_SOUNDS 13 #define MMI_ICONS 14 #define MMI_MOVES 15 /* Define initialise and shutdown methods */ tBlkHandle mmibm_Initialise( tBlkHandle BlkBase, int NumEntries ); void mmibm_ShutDown( tBlkHandle *BlkHandle ); /* Since this module will be managing each of the block handlers for each of the resources, we need to be able to supply the appropriate handle for any given type to the calling routine. */ tBlkHandle mmibm_SupplyResourceHandler( tBlkHandle ManagerHandle, tBlkId Id ); /******************************************************************************* End of File *******************************************************************************/ #endif