FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiBookServices.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _MMI_BOOK_SERVICES_H_ #define _MMI_BOOK_SERVICES_H_ 1 /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: PhoneBook $File: MmiBookServices.h $Revision: 1.0 $Author: Condat(UK) $Date: 25/10/00 ******************************************************************************** Description: This module provides the basic phone book services required by the other phone book modules ******************************************************************************** $History: MmiMsgs.c June 07, 2005 REF: CRR MMI-FIX-31545 x0021334 Issue description: SIM: wrong behavior when FDN is not allocated in SST Solution: Before displaying the FDN options, a check is made if FDN is allocated. Only if FDN is allocated, the options are displayed. Jul 28, 2004 REF: CRR:20887 xrashmic - SASKEN Description: Current state of FDN not highlighted Fix: Instead of showing the submenu directly we call this function where we set the menu and also higlight the previously selected menu item 25/10/00 Original Condat(UK) BMI version. $End *******************************************************************************/ /******************************************************************************* Public Methods *******************************************************************************/ #define READ 3 #define WRITE 6 /* initialise and exit the phone book application */ void bookInitialise( MfwHnd parent ); /* SPR#1112 - Internal phonebook */ #ifdef INT_PHONEBOOK void bookInitInternal( void); UBYTE bookGetBookSelected(void); // RAVI void bookSetBookSelected(UBYTE bookSelected); UBYTE bookGetBookAvailable(void); // RAVI void bookSetBookAvailable(UBYTE bookAvailable); #endif void bookExit( void ); /* The following services are provided by this module */ int bookFindNameInPhonebook( const char* p_pszNumber, T_MFW_PHB_ENTRY* p_pEntry ); /* SPR#1112 - SH - Add this function */ int bookFindNameInSpecificPhonebook( const char *p_pszNumber, T_MFW_PHB_ENTRY *p_pEntry ); /* Find a number given a position in the book */ UBYTE bookFindNumberByPosition( UBYTE index, T_MFW_PHB_ENTRY* p_pEntry ); /* Show an information dialog */ void bookShowInformation( MfwHnd parent, int txtId, char *text, T_VOID_FUNC cb_function ); /* SPR1112 - SH - Show an info screen */ T_MFW_HND bookShowInfoScreen( MfwHnd parent, int txtId1, int txtId2, T_VOID_FUNC cb_function, USHORT Identifier, ULONG Time); /* Add name when the number is already known */ void bookAddName(T_MFW_HND win,char* number); /* Call index */ int bookCallIndex(UBYTE index); /* Convert GSM strings to their alphanumeric equivalent */ void bookGsm2Alpha( UBYTE *alpha ); /* Determine type of current phone book, FDN/ADN */ UBYTE bookActiveBook( int process ); /* Default call backs for name and number entry */ /* SPR#1428 - SH - Moved these from MmiBookInputWindow.h */ #ifdef NEW_EDITOR MfwHnd bookInputStartNameEditor( MfwHnd parent, void *buffer ); MfwHnd bookInputStartNumberEditor( MfwHnd parent, void *buffer ); void bookInputDestroy( MfwHnd window ); void bookAddNameCB( T_MFW_HND win, USHORT Identifier, SHORT reason ); void bookAddNumberCB( T_MFW_HND win, USHORT Identifier, SHORT reason ); #else /* NEW_EDITOR */ void bookAddNameCB( T_MFW_HND win, UBYTE reason ); void bookAddNumberCB( T_MFW_HND win, UBYTE reason ); #endif /* NEW_EDITOR */ /* Memory view */ void bookMemoryView( void ); /* Delete entry from phone book */ void bookDeleteEntry(T_MFW_HND Window); void bookActivateFDN( T_MFW_HND window ); int bookFDNMenu(MfwMnu* menu, MfwMnuItem* item);//MMI SPR 18555 // Jul 28, 2004 REF: CRR:20887 xrashmic - SASKEN void settingsFocusFDNCurSel(void); // June 07, 2005 REF: CRR MMI-FIX-31545 x0021334 // Issue description: SIM: wrong behavior when FDN is not allocated in SST // Added prototype for function to check if FDN is allocated void checkFDNSupport(void); /******************************************************************************* End of File *******************************************************************************/ #endif