FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiCameraTest.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _MMICAMERATEST_H_ #define _MMICAMERATEST_H_ /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: CameraTest $File: MmiCameraTest.h $Revision: 1.0 $Author: Texas Instruments France $Date: 16/06/04 ******************************************************************************** Description: This module provides the Camera functionality. ******************************************************************************** $History: MmiCameraTest.h Aug 22 2005, xpradipg - LOCOSTO-ENH-31154 Description: Application to test camera Solution: Implemented the camera application with following functionalities preview, snapshot and image saving. 16/06/04 $End *******************************************************************************/ /******************************************************************************* Include files *******************************************************************************/ /******************************************************************************* Interface constants *******************************************************************************/ /******************************************************************************* Public methods *******************************************************************************/ /* pretty standard initialise, execute and exit methods */ GLOBAL int mmi_camera_test_launch_view_finder (MfwMnu* m, MfwMnuItem* i); T_MFW_HND mmi_camera_test_opt_create(T_MFW_HND parent); GLOBAL int mmi_camera_test_set_quality (MfwMnu* m, MfwMnuItem* i); GLOBAL int mmi_camera_test_set_color (MfwMnu* m, MfwMnuItem* i); T_MFW_HND mmi_camera_test_opt_start(T_MFW_HND parent_window, MfwMnuAttr *menuAttr); int M_exeQuality(MfwMnu* m, MfwMnuItem* i); int M_exeColor(MfwMnu* m, MfwMnuItem* i); static int M_exeZoom(MfwMnu* m, MfwMnuItem* i); GLOBAL int mmi_camera_edit_filename(MfwMnu* m, MfwMnuItem* i); /******************************************************************************* End of File *******************************************************************************/ #endif //_MMICAMERATEST_H_