FreeCalypso > hg > fc-magnetite

view src/aci2/bmi/mmiDictionary.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3c2acfa1a72f
children
line wrap: on
line source

#ifndef _DICTIONARY_H_
#define _DICTIONARY_H_
/*******************************************************************************

					CONDAT (UK)

********************************************************************************

 This software product is the property of Condat (UK) Ltd and may not be
 disclosed to any third party without the express permission of the owner.
                                                                              
********************************************************************************

 $Project name:	Basic MMI                                                      
 $Project code:	BMI                                                        
 $Module:		MMI
 $File:		    MmiDictionary
 $Revision:		1.0                                                       
                                                                              
 $Author:		Condat(UK)                                                         
 $Date:		                                                      
                                                                               
********************************************************************************
                                                                              
 Description:  Headers of predictive text dictionary functions.  
 Interfaces between the Lation text editor and the EziText API.
                        
********************************************************************************
 $History: MmiDictionary.h

	
	   
 $End

*******************************************************************************/
//#include "STDDEFS.H"
#define ENGLISH 1

//initialising dictionary given language and entry mode e.g. stroke, pinyin
int Initialize_Dict(UBYTE language, UBYTE entry_mode);

//add a char to end of word, returns first matching candidate
int DictAlphaKeyPress(UBYTE keycode, char* first_candidate);


//candidate selected
//need to reset everything.
int  ResetDictSearch();

//get the next set of candidates
//At the moment we only get one candidate at a time, but this allows us to get more than one
int MoreCandidates(char* first_candidate, int* no_of_candidates);

//takes in a string and converts it to keypresses, getting the first matching candidate back
int ConvertToKeyPresses(char* string, char* first_candidate);

//deletes the last char off the current word
int DictBackSpace(char* first_candidate);

#endif