FreeCalypso > hg > fc-magnetite

view src/aci2/bmi/mmiEditor_i.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3c2acfa1a72f
children
line wrap: on
line source


/*******************************************************************************

					CONDAT (UK)

********************************************************************************                                                                              

 This software product is the property of Condat (UK) Ltd and may not be
 disclosed to any third party without the express permission of the owner.                                 
                                                                              
********************************************************************************

 $Project name:	Basic MMI                                                      
 $Project code:	BMI (6349)                                                           
 $Module:		MMI
 $File:		    MmiEditor_i.h
 $Revision:		1.0                                                       
                                                                              
 $Author:		Condat(UK)                                                         
 $Date:		    25/10/00                                                      
                                                                               
********************************************************************************
                                                                              
 Description:
 
    This module provides utility functions for the phone book.

                        
********************************************************************************

 $History: MmiEditor_i.h

	25/10/00			Original Condat(UK) BMI version.	
	   
 $End

*******************************************************************************/


#ifndef _DEF_MMIEDITOR_I_H_
#define _DEF_MMIEDITOR_I_H_


#define MAX_EDITOR_LABEL_LENGTH 160


/* KGT:
 *		internal modes
 */ 
typedef enum
{
    E_NORMAL_MODE = 0,
    E_PIN_SECURITY
} T_E_EDIT_MODE;


/* 
 * Internal struct
 */
typedef struct
{
    T_MMI_CONTROL   mmi_control;
    T_MFW_HND       parent;
    T_MFW_HND       edt_win;
    T_MFW_HND       edt_edt;
    T_MFW_HND       edt_kbd;
    T_MFW_HND       edt_kbd_long;
    T_MFW_HND       edt_tim; // c015 rsa
	T_MFW_HND		edt_input; // RM 25-08

    T_EDITOR_DATA   editor_data;

	//GW-SPR#1035-Added SAT changes.
/* NM, 090702
   increase the size of the LabelText to 161 ;
   need it for the SAT application
   
    /* JVJ-SPR#1208 - The size of this label doesnt have to be as big as concatenated SMS*/
    char            LabelText[MAX_EDITOR_LABEL_LENGTH];    
 /* NM, 090702 END */
	char			*tmpBuf; /* KGT 06-09: used for hide mode. the normal editor buffer will be used
								to display '*' instead of the typed letters and numbers.
								the real typed string will be stored in tmpBuf */

	T_E_EDIT_MODE	edt_mode;//KGT 27-08
	UBYTE			destroyEditor;
	UBYTE			emergency_call;	
	UBYTE			ss_string;
	char			imei[16];
	
}
T_EDITOR_INFO;


#endif