FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiEm.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _MMI_EM_H_ #define MMI_EM_H_ /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: Engineering mode $File: MmiEm.h $Revision: 1.0 $Author: Condat(UK) $Date: 23/09/02 ******************************************************************************** Description: Handles Engineering mode at MMI level ******************************************************************************** /******************************************************************************* Include files *******************************************************************************/ #include "mfw_mfw.h" #include "mfw_mnu.h" /******************************Function Prototypes*******************************/ void mmi_em_init(); void mmi_em_exit(); /*Called from menu; begins process to display Mobile Information*/ int Mmi_em_display_mobile_info_data(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display Serving Cell parameters*/ int Mmi_em_display_serving_cell_params(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display Neighbouring Cell parameters*/ int Mmi_em_display_neighbour_cell_params(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display Locationparameters*/ int Mmi_em_display_location_params(MfwMnu* m, MfwMnuItem*i ); /*begins process to display Ciphering, hopping and discontinuous transmission parameters*/ int Mmi_em_display_ciph_hop_DTX_params(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display GPRS specific parameters*/ int Mmi_em_display_GPRS_params(MfwMnu* m, MfwMnuItem* i); /*Starts the engineering mode menu*/ void mmi_em_start_eng_mode_menus(T_MFW_HND parent); #endif