FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiEmsCreate.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _DEF_MMI_EMSCREATE_H_ #define _DEF_MMI_EMSCREATE_H_ /******************************************************************************* TI (Shanghai) ******************************************************************************** This software product is the property of TI (Shanghai) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: TISHMMS Project $Project code: BMI (6349) $Module: EMS $File: MmiMMSCreate.h $Revision: 1.0 $Author: Pinghua (pinghua-zhang@ti.com) $Date: 26/08/03 ******************************************************************************** Description: This module provides definitions of the types and constants which are shared across the MMS application modules. ******************************************************************************** $History: MmiEMSCreate.h xrashmic 13 Sep, 2004 MMI-SPR-24744 26/08/03 Original TI(Shanghai) BMI version. $End *******************************************************************************/ /******************************************************************************* Include Files *******************************************************************************/ #include "mfw_mfw.h" /******************************************************************************* Shared Structure Definitions *******************************************************************************/ /* #define MENU_TEXT_LENGTH 16 //TBD: to include in common .h #define MENU_HEADER_LENGTH MENU_TEXT_LENGTH - 4 //TBD: to include in common .h #define MAX_MMS_TEXT_LEN 32 #define MAX_MMS_TOPIC_LEN 16 */ /******************************************************************************* Function Prototypes *******************************************************************************/ #define MAX_EMS_TEXT_LEN 32 #define MAX_EMS_TOPIC_LEN 16 #define EMS_DELETE_PICTURE 0 #define EMS_DELETE_SOUND 1 #define EMS_DELETE_TEXT 2 T_MFW_HND EMSCreate_OPT_start(T_MFW_HND parent_window, MfwMnuAttr *menuAttr) ; T_MFW_HND EMSCreate_start(T_MFW_HND parent_window, MfwMnuAttr *menuAttr); // xrashmic 13 Sep, 2004 MMI-SPR-24744 void ems_dialog(USHORT TxtId1, USHORT TxtId2, USHORT SoftKeyTxtId1, USHORT SoftKeyTxtId2, int timer); /* T_MFW_HND MMSInbox_start(T_MFW_HND parent_window, MfwMnuAttr *data); T_MFW_HND MMSOutbox_start(T_MFW_HND parent_window, MfwMnuAttr *data); T_MFW_HND MMSSettings_start(T_MFW_HND parent_window, MfwMnuAttr *menuAttr); */ /******************************************************************************* DUMMY DECLARATIONS *******************************************************************************/ //Dummy defines // Dummy global variables #endif /* _DEF_MMI_EMSCREATE_H_ */