FreeCalypso > hg > fc-magnetite

view src/aci2/bmi/mmiFileViewer.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3c2acfa1a72f
children
line wrap: on
line source

#ifndef _MMI_FILEVIEWER_H_
#define _MMI_FILEVIEWER_H_
/*******************************************************************************

          Texas Instruments

********************************************************************************

 This software product is the property of Texas Instruments and may not be
 disclosed to any third party without the express permission of the owner.

********************************************************************************

 $Project name: File Viewer
 $Module:   	File Viewer
 $File:       	MmiFileViewer.h
 $Revision:   	1.0
 $Author:   	xdeepadh - sasken India
 $Date:       	11/05/05

********************************************************************************

 Description:This module contains the functionality of File Viewer Application.

   

********************************************************************************
 $History: MmiFileViewer.h

 	Aug 22, 2005    REF: ENH 31154 xdeepadh
   	Description: Application to Test Camera
   	Solution: Implemeted the Fileviewer to view the jpeg images.Camera Application to 
   	preview,capture and save image has been implemented.

     

 $End

*******************************************************************************/
GLOBAL int LaunchFileViewer( MfwMnu *m, MfwMnuItem *i );
void mmi_fv_init(int* fileCount);
 char *mmi_fv_GetExtension(char *src);
GLOBAL int mmi_fv_reame_edit(MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_fv_set_rotate_90degree (MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_fv_set_rotate_180degree (MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_fv_set_rotate_270degree (MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_fv_set_zoom_out (MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_fv_set_zoom_in (MfwMnu* m, MfwMnuItem* i);
int mmi_fv_view_image_start(MfwMnu* m, MfwMnuItem* i) ;
T_MFW_HND mmi_fv_opt_start(T_MFW_HND parent_window, MfwMnuAttr *menuAttr);
int mmi_fv_rename_file_start(MfwMnu* m, MfwMnuItem* i) ;
int mmi_fv_rotate_start(MfwMnu* m, MfwMnuItem* i);
int mmi_fv_zoom_start(MfwMnu* m, MfwMnuItem* i);
int mmi_fv_delete_start(MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_fv_read_jpeg_file(UBYTE index);
int mmi_fv_rotate_image_start(T_MFW_HND win) ;
#endif //_MMI_FILEVIEWER_H_