FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiGame.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 3c2acfa1a72f |
| children |
line wrap: on
line source
#ifndef _MMI_GAME_H_ #define _MMI_GAME_H_ /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: Calculator $File: Mmigame.h $Revision: 1.0 $Author: Condat(UK) $Date: 03/07/01 ******************************************************************************** Description: This provides the main game functionality ******************************************************************************** ******************************************************************************* Include files *******************************************************************************/ extern T_MFW_HND four_in_a_row_create(MfwHnd parent); //extern void melody_generator_destroy (void); extern void four_in_a_row (T_MFW_HND win, USHORT event, SHORT value, void * parameter); extern int four_in_a_row_kbd_cb (MfwEvt e, MfwKbd *k); extern int four_in_a_row_win_cb (MfwEvt e, MfwWin *w); extern T_MFW_HND four_in_a_row_start (T_MFW_HND win_parent,char *character); /******************************************************************************* Interface types *******************************************************************************/ typedef enum { SHOWGAMEINFO_INIT } GameInfo_events; /******************************************************************************* Public methods *******************************************************************************/ /* pretty standard initialise, execute and exit methods */ int four_in_a_row_aktivate(MfwMnu* m, MfwMnuItem* i); /******************************************************************************* End of File *******************************************************************************/ #endif