FreeCalypso > hg > fc-magnetite

view src/aci2/bmi/mmiSettings.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3c2acfa1a72f
children
line wrap: on
line source

#ifndef _DEF_MMI_SETTINGS_H_
#define _DEF_MMI_SETTINGS_H_

/*******************************************************************************

					CONDAT (UK)

********************************************************************************                                                                              

 This software product is the property of Condat (UK) Ltd and may not be
 disclosed to any third party without the express permission of the owner.                                 
                                                                              
********************************************************************************

 $Project name:	Basic MMI                                                      
 $Project code:	BMI (6349)                                                           
 $Module:		Settings
 $File:		    MmiSettings.h

 	Jul 28, 2004 REF: CRR 20899 xkundadu
	Description: No identification for user whether 'Any-key-Answer' is On/Off
	Solution: Added the function settingsFocusCurSelAnyKeyAns
			prototype.
			
 $Revision:		1.0                                                       
                                                                              
 $Author:		Condat(UK)                                                         
 $Date:		    25/10/00                                                      
                                                                               
********************************************************************************
                                                                              
 Description:
 
                        
********************************************************************************

	May 04, 2005  REF: CRR 30285  x0021334
       Description: SMS Status Request in idle and dedicated mode (using Menu) setting does not work
       Solution: status of sms status request is read and focus is set accrodingly.
    
       March 2, 2005    REF: CRR 11536 x0018858
       Description: Reply path not supported while sending a reply.
       Solution: Added menu option for the reply path.

	Jul 22,2004 CRR:20896 xrashmic - SASKEN
	Description: The current time format is not highlighted
	Fix: Instead of providing the submenu directly we call a function 
	where we set the menu and also higlight the previously selected menu item
	 
 	Jul 29, 2004 REF = CRR 20898 xkundadu
	Description: No identification for user whether 'Auto-Answer' is On/Off
	Solution: Added the function settingsFocusCurSelAutoAns prototype.

       Issue Number : SPR#12822  on 31/03/04 by v vadiraj

*******************************************************************************
                                                                              
                                Required Include Files
                                                                              
*******************************************************************************/

							          
/* PROTOTYPES               */


//  Jul 29, 2004 REF = CRR 20898 xkundadu
// Added the function settingsFocusCurSelAutoAns() prototype.
void settingsFocusCurSelAutoAns(void);
//  Jul 28, 2004 REF: CRR 20899 xkundadu
// Added the function settingsFocusCurSelAnyKeyAns() prototype.
void settingsFocusCurSelAnyKeyAns(void);

T_MFW settingsRecReportControl(UBYTE ReportStatus);
int settingsGetStatus(int flagBit);

int settingsSilentModeOff	(void);
int settingsSilentModeOn	(void);
int settingsKeyPadLockOn	(void);
int settingsKeyPadLockOff	(void);
int settingsAutoRedialOn	(MfwMnu* m, MfwMnuItem* i);
int settingsAutoRedialOff	(MfwMnu* m, MfwMnuItem* i);
int settingsAutoAnswerOn	(MfwMnu* m, MfwMnuItem* i);
int settingsAutoAnswerOff	(MfwMnu* m, MfwMnuItem* i);
int settingsAnyKeyAnswerOn	(MfwMnu* m, MfwMnuItem* i);
int settingsAnyKeyAnswerOff	(MfwMnu* m, MfwMnuItem* i);
int factoryReset			(MfwMnu* m, MfwMnuItem* i);
int settingsVoiceMail		(MfwMnu* m, MfwMnuItem* i);
int settingsScNumber		(MfwMnu* m, MfwMnuItem* i);
int SmsValidityPeriod          (MfwMnu* m, MfwMnuItem* i);
int SmsStatusReportRequest(MfwMnu* m, MfwMnuItem* i); /* Marcus: Issue 1170: 30/09/2002 */
//March 2, 2005    REF: CRR 11536 x0018858
int SmsReplyPathRequest(MfwMnu* m, MfwMnuItem* i); /*Added function declaration for 
                                                     setting reply path*/
void settingsInit (void);
void settingsExit (void);
/* GW Added as external to initialise FFS data when FFS file does not exist*/
void setUserSettings2Default (void);
void settingsShowStateAnykeyAnswer (void);
void settingsShowStateAutoAnswer (void);
void settingsShowStateAutoRedial(void);
void settingsShowStateCBDisable(void);
void settingsSetStatus( int statusId, int setOrClear );
// change by Sasken (VVADIRAJ) on March 31th 2004
// Issue Number : MMI-SPR-12822
void settingsFocusNwIconCurSel(void);

//Jul 22,2004 CRR:20896 xrashmic - SASKEN
void settingsFocusTimeFormatCurSel(void); 

// May 04, 2005  REF: CRR 30285  x0021334
void settingsSmsStatusReportCurSel(void);

#define SET_SETTING		(1)
#define CLEAR_SETTING	(0)

#endif