FreeCalypso > hg > fc-magnetite
view src/aci2/bmi/mmiSmsRead.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 93999a60b835 |
| children |
line wrap: on
line source
#ifndef _DEF_MMI_SMSREAD_H_ #define _DEF_MMI_SMSREAD_H_ #undef GLOBAL_EXT #if defined (MMI_SMSREAD_C) #define GLOBAL_EXT #else #define GLOBAL_EXT extern #endif /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: SMS $File: mmiSmsRead.h $Revision: 1.0 $Author: Condat(UK) $Date: 25/10/00 ******************************************************************************** Description: This module provides definitions of the types and constants which are shared across the phone book application modules. ******************************************************************************** $History: mmiSmsRead.h 25/10/00 Original Condat(UK) BMI version. $End *******************************************************************************/ /******************************************************************************* Include Files *******************************************************************************/ #include "mfw_mfw.h" /******************************************************************************* Shared Structure Definitions *******************************************************************************/ /*SPR 1453*/ #ifdef LSCREEN #define MENU_TEXT_LENGTH 50 #else #define MENU_TEXT_LENGTH 16 //TBD: to include in common .h #endif #define MENU_HEADER_LENGTH MENU_TEXT_LENGTH - 4 //TBD: to include in common .h // Length = to len("from ") + len(number) + len(sms text) + 4 (for \0 \n and optional ionternational character +) #define MAX_EDITOR_LEN (5+MFW_NUM_LEN+MAX_MSG_LEN+4) typedef enum { MMI_SMS_MO, MMI_SMS_MT, MMI_SMS_CB } T_MMI_SMS_STAT; /******************************************************************************* Function Prototypes *******************************************************************************/ T_MFW_HND SmsRead_R_TEXTEDT2_start(T_MFW_HND parent_window, MfwMnuAttr *data); T_MFW_HND SmsRead_R_OPT_start(T_MFW_HND parent_window, MfwMnuAttr *menuAttr); void SmsRead_DisplayStandardDialog(T_MFW_HND win, int TextId, ULONG duration); /******************************************************************************* DUMMY DECLARATIONS *******************************************************************************/ //Dummy defines #define SmsRead_R_ID 100 #define SmsRead_R_TEXTEDT_ID 101 #define SmsRead_R_TEXTEDT2_ID 101 // Specific for approval #define SmsRead_R_OPT_ID 102 #define SmsRead_SMS_DISPLAY_ID 103 #define SmsRead_R_READSMS_OPT_ID 104 #define DEFAULT_FONT -1 #define SMS_APPROVAL 1 // MZ 6/2/01 temp typedefs. typedef char * wstring_t; typedef char * charw_t; typedef ListCbFunc ListCbFunc_t; #endif /* _DEF_MMI_SMSMENU_H_ */