FreeCalypso > hg > fc-magnetite

view src/aci2/bmi/mmiTimeDate.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3c2acfa1a72f
children
line wrap: on
line source

#ifndef _DEF_MMI_TIMEDATE_H_
#define _DEF_MMI_TIMEDATE_H_

/*******************************************************************************

					CONDAT (UK)

********************************************************************************

 This software product is the property of Condat (UK) Ltd and may not be
 disclosed to any third party without the express permission of the owner.
                                                                              
********************************************************************************

 $Project name:	Basic MMI                                                      
 $Project code:	BMI (6349)                                                           
 $Module:		MMI
 $File:		    MmiTimeDate.h
 $Revision:		1.0                                                       
                                                                              
 $Author:		Condat(UK)                                                         
 $Date:		    25/10/00                                                      
                                                                               
********************************************************************************
                                                                              
 Description:

    This provides the root mofule for the basic MMI
                        
********************************************************************************
 $History: MmiTimeDate.h

 	Jan 06,2004 REF: CRR 27859 xkundadu
	Description:  Clock: Alarm does not go off even if timer times out.
	Solution: If the mfw_td_set_alarm() function fails, display the 
	'Write Failed" message.
        Added 'TIDA_SAVEFAILED' enum to display 'Write Failed' for set alarm fail case.


	   
 $End

*******************************************************************************/
#include "mfw_ffs.h"


#define ALLOC_MEMORY mfwAlloc
#define FREE_MEMORY  mfwFree

/* SPR#1428 - SH - New Editor changes
 * New time/date data */
 
#ifdef NEW_EDITOR

typedef enum
{
	TIDA_INIT,			/* Initialise */
	TIDA_DATE, 			/* Enter date */
	TIDA_TIME,			/* Enter time */
	TIDA_ALARMDATE,		/* Enter alarm date */
	TIDA_ALARMTIME,		/* Enter alarm time */
	TIDA_SAVE,			/* Save data to flash & display "Saved" dialog */

//	Jan 06,2004 REF: CRR 27859 xkundadu
//	Description:  Clock: Alarm does not go off even if timer times out.
//	Solution: If the mfw_td_set_alarm() function fails, display the 
//	'Write Failed" message.

//    Added 'TIDA_SAVEFAILED' enum to display 'Write Failed' for set alarm fail case.
	TIDA_SAVEFAILED  // 
};

T_MFW_HND tida_create(T_MFW_HND parent_win);
T_MFW_HND tida_destroy(T_MFW_HND win);

#else /* NEW_EDITOR */

/* OLD VERSION */

/* REASONS                  */
typedef enum
{
	DATE_SHOW = TimeDateDummy,
	TIME_SHOW,
	DATE_ENTRY,
	TIME_ENTRY,
	ENTRY_OK,
	SAVED,
	TIDA_ABORT,
	TIDA_CLEAR,
	TIDA_TO_IDLE
}
DAT_TIME_CASE;
void time_date_init();
void tida_info_cb(T_MFW_HND win, USHORT identifier, UBYTE reasons);
void date_time_edt_destroy  (T_MFW_HND own_window);
T_MFW_HND date_time_edt_create(T_MFW_HND parent_window);
void date_time_destroy  (T_MFW_HND own_window);
T_MFW_HND date_time_create (T_MFW_HND parent_window);
void time_date_delete();

#endif /* NEW_EDITOR */


/* Functions below are common to old and new versions */

/* PROTOTYPES               */
//menu handler functions                                        
int alarmTimeDate(MfwMnu* m, MfwMnuItem* i);
int settingsTimeDate(MfwMnu* m, MfwMnuItem* i);
int clear_alarm(MfwMnu* m, MfwMnuItem* i);
int twelve_hour_clock(MfwMnu* m, MfwMnuItem* i);
int twentyfour_hour_clock(MfwMnu* m, MfwMnuItem* i);
void alarm_check(void);  // RAVI

#endif