FreeCalypso > hg > fc-magnetite

view src/aci2/bmi/mmiTimers.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 3c2acfa1a72f
children
line wrap: on
line source

#ifndef _DEF_MMI_TIMERS_H_
#define _DEF_MMI_TIMERS_H_
/*******************************************************************************

					CONDAT (UK)

********************************************************************************

 This software product is the property of Condat (UK) Ltd and may not be
 disclosed to any third party without the express permission of the owner.
                                                                              
********************************************************************************

 $Project name:	Basic MMI                                                      
 $Project code:	BMI (6349)                                                           
 $Module:		MMI
 $File:		    MmiTimers.h
 $Revision:		1.0                                                       
                                                                              
 $Author:		Condat(UK)                                                         
 $Date:		    25/10/00                                                      
                                                                               
********************************************************************************
                                                                              
 Description:

    This handles the storage of call times.
                        
********************************************************************************
 $History: MmiTimers.h


	   
 $End

*******************************************************************************/
#include "MmiBookShared.h"

typedef enum
{
	LAST_CALL,
	OUTGOING_CALLS,
	INCOMING_CALLS
} timer_types;

/*SPR 2142 removed timer window data structure*/


void setLastCallDuration(long call_time, T_MFW_CM_CALL_DIR call_direction);
int timerLastCall(MfwMnu* m, MfwMnuItem* i);
int timerIncomingCalls(MfwMnu* m, MfwMnuItem* i);
int timerOutgoingCalls(MfwMnu* m, MfwMnuItem* i);
void resetIncomingCallsDuration( void );
void resetOutgoingCallsDuration( void );

#endif