FreeCalypso > hg > fc-magnetite
view src/aci2/mfw/mfw_aud.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 93999a60b835 |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------+ | PROJECT: MMI-Framework (8417) $Workfile:: mfw_aud.h $| | $Author:: NDH $Revision:: 1 $| | CREATED: 04.02.03 $Modtime:: 10.04.00 14:58 $| | STATE : code | +--------------------------------------------------------------------+ MODULE : MFW_AUD PURPOSE : This module contains the definitions for the Audio Riveria Interface. */ /* ** Voice Memo Functions Prototypes */ SHORT mfw_aud_vm_delete_file(void); SHORT mfw_aud_vm_start_playback(void (*callback_fn)(void *)); SHORT mfw_aud_vm_stop_playback(void (*callback_fn)(void *)); SHORT mfw_aud_vm_start_record(UBYTE max_duration, void (*callback_fn)(void *)); SHORT mfw_aud_vm_stop_record(void (*callback_fn)(void *)); UBYTE mfw_aud_vm_get_duration(void); void mfw_aud_vm_set_duration(UBYTE duration); /* ** Layer1 Audio interface functions */ void mfw_aud_l1_enable_vocoder ( void ); void mfw_aud_l1_disable_vocoder ( void ); /* ** Voice Memo Return Values */ #define MFW_AUD_VM_OK (0) #define MFW_AUD_VM_RIVIERA_FAILED (-1) #define MFW_AUD_VM_MEM_FULL (-2) #define MFW_AUD_VM_MEM_EMPTY (-3)