src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

#ifndef _MFW_BAND_H_
#define _MFW_BAND_H_

typedef enum
{	MFW_BAND_Busy= -2,
	MFW_BAND_Fail = -1,
	MFW_BAND_OK,
	MFW_BAND_InProgress
} T_MFW_BAND_RET;

typedef enum
{
	MFW_BAND_MODE_Auto	=  0,
	MFW_BAND_MODE_Manual	=  1
} T_MFW_BAND_MODE;

/* SPR919 - SH - Band is now a bit field*/
typedef enum
{
	MFW_BAND_GSM_900		=	1,
	MFW_BAND_DCS_1800		=	2,
	MFW_BAND_PCS_1900		=	4,
	MFW_BAND_E_GSM			=	8,
	MFW_BAND_GSM_850		=	16
};

T_MFW_BAND_RET band_radio_mode_switch(T_MFW_BAND_MODE mode, UBYTE band);

T_MFW_BAND_RET band_get_radio_modes(T_MFW_BAND_MODE* maxMode, UBYTE *band);

T_MFW_BAND_RET band_get_current_radio_mode(T_MFW_BAND_MODE* mode, UBYTE *band);
#endif /* _MFW_BAND_H_*/