FreeCalypso > hg > fc-magnetite

view src/aci2/mfw/mfw_bt_op.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+-------------------------------------------------------------------+
| PROJECT: MMI-Framework (8445)         $Workfile:: mfw_bt_op.h				$|
| $Author:: NDH					     $Revision::  1						$|
| CREATED: 17.04.04				     $Modtime:: 17.04.04 10:48			$|
| STATE  : code														 |
+-------------------------------------------------------------------+


   MODULE  : MFW_BT

   PURPOSE : This module contains the definitions for MFW Bluetooth Object Push Profile

*/

#ifndef DEF_MFW_BT_OP_HEADER
#define DEF_MFW_BT_OP_HEADER

#include "bta_op_api.h"
#include "mfw_bte.h"

/*
** The following Macros define the Object Push Signals (BT -> Mfw)
*/
#define T_MFW_BT_OPC_EVT				tBTA_OPC_EVT
#define T_MFW_BT_OPC_SIG_DATA		tBTA_OPC

#define T_MFW_BT_OPS_EVT				tBTA_OPS_EVT
#define T_MFW_BT_OPS_SIG_DATA		tBTA_OPS

/*
** Event Identifiers (Mfw -> BMI)
*/


/*
** Event Parameter Structure Definitions
*/

typedef struct {
	UINT32 dummy;
}T_MFW_BT_OP_DUMMY_SIG;

/*
** Bluetooth Object Push Profile Prototypes
*/
void	mfw_bt_opc_cb(T_MFW_BT_OPC_EVT event, T_MFW_BT_OPC_SIG_DATA *data);
void	mfw_bt_ops_cb(T_MFW_BT_OPS_EVT event, T_MFW_BT_OPS_SIG_DATA *data);

T_MFW_BT_STATUS mfw_bt_opc_hndlr (T_MFW_BT_OPC_EVT event, T_MFW_BT_OPC_SIG_DATA *data);
T_MFW_BT_STATUS mfw_bt_ops_hndlr (T_MFW_BT_OPS_EVT event, T_MFW_BT_OPS_SIG_DATA *data);
T_MFW_BT_STATUS mfw_bt_op_init( void );

#endif