src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

/*
+--------------------------------------------------------------------+
| PROJECT: MMI-Framework (8445)         $Workfile:: mfw_bta.h       $|
| $Author:: Rm                          $Revision::  1              $|
| CREATED: 05.01.01                     $Modtime:: 05.01.01 12:21   $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

	PURPOSE :  This modul contains the definition for BT management.
    .
*/

#ifndef DEF_MFW_BTA_HEADER
#define DEF_MFW_BTA_HEADER

EXTERN BOOL bta_response_cb (ULONG opc, void * data);

EXTERN T_MFW_BT_SERVICE_LST found_headset;
EXTERN T_MFW_BT_SERVICE_LST found_dial_up;
EXTERN T_MFW_BT_SERVICE_LST found_fax;
EXTERN T_MFW_BT_SERVICE_LST found_opp;
EXTERN T_MFW_BT_SERVICE_LST found_sync;
EXTERN T_MFW_BT_SERVICE_LST found_sync_cmd;

EXTERN T_MFW_BT_DEVICE_LST service_list;

#endif