FreeCalypso > hg > fc-magnetite

view src/aci2/mfw/mfw_ext.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: MMI-Framework (8417)         $Workfile:: mfw_ext.c       $|
| $Author:: Es  $ CONDAT GmbH           $Revision:: 2               $|
| CREATED: 29.01.99                     $Modtime:: 4.02.99 19:39    $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

   MODULE  : MFW_EXT

   PURPOSE : MFW external communication

   EXPORT  :

   TO DO   :

   $History:: mfw_ext.c                                             $
 * 
 * *****************  Version 2  *****************
 * User: Es           Date: 17.02.99   Time: 20:00
 * Updated in $/GSM/DEV/MS/SRC/MFW
 * 
 * *****************  Version 1  *****************
 * User: Es           Date: 9.02.99    Time: 14:53
 * Created in $/GSM/DEV/MS/SRC/MFW
 * TI display & keyboard interface for MFW
*/

#include <stdio.h>
#include <string.h>

#include "mfw_mmi.h"
#include "drv_key.h"


//extern void ext_syscmd (char *cmd, char *from, char *to);
extern void scrMobCommand (char *cmd);     /* ext_syscmd to driver     */


/*
+--------------------------------------------------------------------+
| PROJECT : MMI-Framework (8417)        MODULE  : MFW_EXT            |
| STATE   : code                        ROUTINE : mfwExtIn           |
+--------------------------------------------------------------------+

  PURPOSE : execute incoming command

*/

int mfwExtIn (char *cmd)
{
    if (!strncmp("KBD ",cmd,4))
    {
        unsigned int upDown, key;
        sscanf(cmd+4,"%d,%d",&upDown,&key);
        drvKeyUpDown((char) upDown,(char) key);
    }
    else if (!strncmp("SCR ",cmd,4))
    {
        scrMobCommand(cmd+4);
    }
    else if (!strncmp("MFW init",cmd,8))
    {
        mmiInit();
    }
    else if (!strncmp("MFW exit",cmd,8))
    {
        mmiExit();
    }
    else
        return 0;

    return 1;
}


/*
+--------------------------------------------------------------------+
| PROJECT : MMI-Framework (8417)        MODULE  : MFW_EXT            |
| STATE   : code                        ROUTINE : mfwExtOut          |
+--------------------------------------------------------------------+

  PURPOSE : forward outgoing command

*/

int mfwExtOut (char *cmd)
{
//    ext_syscmd(cmd,"MMI","PCO");

    return 1;
}