FreeCalypso > hg > fc-magnetite

view src/aci2/mfw/mfw_fv.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT:	MMI-Framework (8417)		$Workfile::	mfw_fv.h	    $|
| $Author::	NDH							$Revision::	1			    $|
| CREATED:	21.05.04		     		$Modtime::	21.05.04	 14:58	$|
| STATE  :	code														 |
+--------------------------------------------------------------------+

   MODULE  : MFW_FV

   PURPOSE :This module contains File Viewer Interface functions.

   HISTORY  :

    Aug 22, 2005    REF: ENH 31154 xdeepadh
   	Description: Application to Test Camera
   	Solution: Implemeted the Fileviewer to view the jpeg images.Camera Application to 
   	preview,capture and save image has been implemented.
	

*/
#ifndef DEF_MFW_FV
#define DEF_MFW_FV

//Defines 

#define SCREEN_SIZE_X 				176	
#define SCREEN_SIZE_Y 				220	
#define  SK_HEIGHT_LATIN				24

#define FV_DSPL_WIDTH 				 SCREEN_SIZE_X
#define FV_DSPL_HEIGHT 				 (SCREEN_SIZE_Y - SK_HEIGHT_LATIN)
#define FV_DSPL_VOLUME 				FV_DSPL_WIDTH * FV_DSPL_HEIGHT

#define  FV_SCALE_VOLUME  			 FV_DSPL_VOLUME / 4

#define MFW_ZOOM_WIDTH_DELTA  	32
#define MFW_ZOOM_HEIGHT_DELTA  	35 


//Defines for zooming
#define FV_NO_ZOOM 		0
#define FV_ZOOM_IN 		1
#define FV_ZOOM_OUT 	2

//Defines for rotation
#define FV_ROTATE_90	 0
#define FV_ROTATE_180 	 1
#define FV_ROTATE_270 	 2
#define FV_ROTATE_360 	 3

int mfw_fv_decode_image(UBYTE * inputbuffer, int size);
SHORT  mfw_fv_zoom_image();
SHORT  mfw_fv_rotate_image();

#endif  //DEF_MFW_FV