FreeCalypso > hg > fc-magnetite

view src/aci2/mfw/mfw_mmi.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: MMI-Framework (8417)         $Workfile:: mfw_mmi.h       $|
| $Author:: Es  $ CONDAT GmbH           $Revision:: 3               $|
| CREATED: 21.09.98                     $Modtime:: 2.02.99 17:02    $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

   MODULE  : MFW_MMI

   PURPOSE : MMI MFW application

   EXPORT  :

   TO DO   :

   $History:: mfw_mmi.h                                             $
 * 
 * *****************  Version 3  *****************
 * User: Es           Date: 17.02.99   Time: 20:00
 * Updated in $/GSM/DEV/MS/SRC/MFW
 * 
 * *****************  Version 2  *****************
 * User: Es           Date: 8.02.99    Time: 19:07
 * Updated in $/GSM/DEV/MS/SRC/MFW
 * 
 * *****************  Version 1  *****************
 * User: Es           Date: 8.12.98    Time: 16:59
 * Created in $/GSM/DEV/MS/SRC/MFW
*/

#ifndef _DEF_MFW_MMI_H_
#define _DEF_MFW_MMI_H_


                                        /* PROTOTYPES               */
void mmi_main (void);
void mmiInit (void);
void mmiExit (void);


/************************************************************************

The following definitions are procedures in the BMI that are accessed by the MFW.

This header file should be included by any MFW procedure that calls a BMI function

and by the BMI procedures that define the functions to ensure that the definitions

match

************************************************************************/

/**********************/
/* From MMIResources  */
/**********************/

//Function to get string associated with an ID
char *MmiRsrcGetText( int Id );

//Functions to select/restore colour
void resources_setColour(unsigned int colIndex);
void resources_setSKColour(unsigned int colIndex);
void resources_setHLColour(unsigned int colIndex);
void resources_setTitleColour(unsigned int colIndex);

void resources_restoreColour( void );
void resources_restoreMnuColour(void);

void resources_setColourMnuItem( int txtId);

//Function to get the height allocated for the menu title
int res_getTitleHeight( void );


#endif