FreeCalypso > hg > fc-magnetite

view src/aci2/mfw/mfw_sima.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 93999a60b835
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: GSM-MFW (?)                  $Workfile:: mfw_sima.h      $|
| $Author:: Es                          $Revision::  1              $|
| CREATED: 14.10.98                     $Modtime:: 6.10.99 12:21    $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

	PURPOSE :  Types definitions for MMI framework 
    .

	Jan 16, 2006 DR: OMAPS00061460 - Shashi Shekar B.S.
	Description: SAT Icon support
	Solution : SAT icon support added.

*/

#ifndef DEF_MFW_SIMA_HEADER
#define DEF_MFW_SIMA_HEADER

/* Contents of the Elementary Files from SIM card */
typedef struct
{
  UBYTE display_condition;
  UBYTE service_provider [LONG_NAME];
} T_EF_SPN;

// Shashi Shekar B.S., a0876501, Jan 16, 2006, DR: OMAPS00061460
#ifdef FF_MMI_SAT_ICON
/* SIM record read parameters */
typedef struct
{
	USHORT data_id;			/* EF file to be read */
	USHORT offset;			/* Offset to file to be read */
	UBYTE  record_number;	/* Record number of EF file */
	UBYTE  len;				/* Length of record */
	UBYTE  max_length;		/* Max records */
} T_SIM_ACCESS_PARAM;

/* Structure to hold the Image instance contents */
typedef struct
{
  UBYTE  image_width;				/* Image Width */
  UBYTE  image_height;				/* Image Height*/
  UBYTE  image_coding;				/* 11 -> B/W, 21 -> Color image, xx -> RFU */
  USHORT image_instance_file_id;	/* File Id of the image instance */
  USHORT image_offset;				/* Offset of the image instance */
  USHORT image_instance_length;     /* Length of image instance data */
} T_IMAGE_INSTANCE;

/* Contents of the Elementary Files from SIM card for IMG */
typedef struct
{
  UBYTE number_of_image_instance;
  T_IMAGE_INSTANCE image_instance;
} T_EF_IMG;
#endif

EXTERN void  sima_init       (void);
EXTERN void  rAT_PlusCFUNP   (T_SIM_MMI_INSERT_IND * mmi_insert_ind);
EXTERN UBYTE qAT_PlusCPINNO  (void);
EXTERN void  sim_read_sim    (USHORT data_id, UBYTE len, UBYTE max_length);
// Shashi Shekar B.S., a0876501, Jan 16, 2006, DR: OMAPS00061460
#ifdef FF_MMI_SAT_ICON
EXTERN void  sim_read_sim_icon(T_SIM_ACCESS_PARAM *sim_icon_read_param);
#endif
EXTERN void  sim_read_sim_cb (SHORT table_id);
EXTERN void  sim_write_sim   (USHORT data_id, UBYTE * data, UBYTE length);
EXTERN void  sim_write_sim_cb(SHORT table_id);


#endif