FreeCalypso > hg > fc-magnetite
view src/aci2/mfw/mfw_simi.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 93999a60b835 |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------+ | PROJECT: GSM-MFW (?) $Workfile:: mfw_simi.h $| | $Author:: Vo $Revision:: 1 $| | CREATED: 14.10.98 $Modtime:: 20.03.00 11:48 $| | STATE : code | +--------------------------------------------------------------------+ PURPOSE : Internal definitions for SIM management of MMI framework */ #ifndef DEF_MFW_SIMI_HEADER #define DEF_MFW_SIMI_HEADER #include "message.h" #include "prim.h" #include "aci_cmh.h" #define NO_ALLOCATED 0 #define ALLOCATED_AND_DEACTIVATED 2 #define ALLOCATED_AND_ACTIVATED 3 #define SIM_UBLK_ERROR 0 #define SIM_UBLK_OK 1 #define SIM_PIN2_FAILURE 17 #define SIM_PUK2_FAILURE 18 #define MFW_LEN_PLMN_NTRY 3 /* SIM configuration information */ typedef struct { UBYTE deper_key [16]; UBYTE phase; UBYTE oper_mode; /* SIM card functionality */ UBYTE pref_lang[5]; UBYTE access_acm; UBYTE access_acmmax; UBYTE access_puct; UBYTE sim_gidl1[5]; UBYTE sim_gidl2[5]; } T_MFW_SIM_CONFIG; /* * SIM Control Block */ typedef struct { T_MFW_EVENT emask; /* events of interest */ T_MFW_EVENT event; /* current event */ T_MFW_CB handler; T_MFW_SIM_PARA para; } T_MFW_SIM; EXTERN T_MFW_HND sim_install (T_MFW_HDR *w, T_MFW_HDR *h, T_MFW_SIM *sim); EXTERN T_MFW_RES sim_remove (T_MFW_HDR *h); EXTERN int sim_sign_exec (T_MFW_HDR * hdr, T_MFW_EVENT event, T_MFW_SIM_PARA *para); EXTERN void sim_spn_req (void); EXTERN void sim_ok_cfun (void); EXTERN void sim_error_cfun (UBYTE reason); EXTERN void sim_ok_cpin (void); EXTERN void sim_error_cpin (T_ACI_CME_ERR reason); EXTERN void sim_ok_cpinc (void); EXTERN void sim_error_cpinc (void); EXTERN void sim_ok_cpind (void); EXTERN void sim_error_cpind (void); EXTERN void sim_ok_cpine (void); EXTERN void sim_error_cpine (void); EXTERN UBYTE sim_check_service (UBYTE nr, UBYTE * serv_table); EXTERN T_MFW sim_status_check (void); EXTERN void decode_imsi (UBYTE simlck[], UBYTE imsi_id[LONG_NAME]); EXTERN void sim_mmi_parameter (T_SIM_ACTIVATE_CNF *sim_activate_cnf); EXTERN void sim_ss_unblock (UBYTE result, T_ACI_CME_ERR reason); EXTERN void sim_simlock_timeout (void); EXTERN T_MFW sim_simlock_status (UBYTE status); EXTERN UBYTE sim_cvtPINstatus (T_ACI_PVRF_STAT ps, UBYTE type); EXTERN void sim_gid1_cnf (SHORT error, UBYTE *data); EXTERN void sim_gid2_cnf (SHORT error, UBYTE *data); EXTERN void sim_pin_ident (UBYTE id); EXTERN T_MFW sim_check_imsi_digit (UBYTE pcm_imsi, UBYTE sim_imsi); EXTERN void sim_mmi_update_parameter(T_SIM_ACTIVATE_IND *sim_act_ind); EXTERN void sim_sat_file_update (USHORT dataId); EXTERN void sim_read_sst_cnf (SHORT error, UBYTE *data); EXTERN void sim_read_lp_cnf (SHORT error, T_ACI_LAN_SUP *CLang); #endif