FreeCalypso > hg > fc-magnetite
view src/aci2/mfw/mfw_td.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | d5bbfb9649d5 |
children |
line wrap: on
line source
#ifndef _MFW_TD_H_ #define _MFW_TD_H_ /* +--------------------------------------------------------------------+ | PROJECT: MMI-Framework (8417) $Workfile:: mfw_td.c $| | $Author:: NDH $Revision:: 1 $| | CREATED: 03.03.2003 $Modtime:: 10.04.00 14:58 $| | STATE : code $| +--------------------------------------------------------------------+ MODULE : MFW_TD PURPOSE : This modul contains Time and Date functionality. */ #include <string.h> #if defined (NEW_FRAME) #include "typedefs.h" #include "vsi.h" #include "pei.h" #include "custom.h" #include "gsm.h" #else #include "STDDEFS.H" #include "custom.h" #include "gsm.h" #include "vsi.h" #endif #include "mfw_mfw.h" #include "mfw_utils.h" #include "cus_aci.h" #include "prim.h" #include "pcm.h" #include "rtc.h" /***************************Data types**************************************** **/ #define T_MFW_TIME T_RTC_TIME #define T_MFW_DATE T_RTC_DATE typedef enum { MFW_TIME_FORMAT_12HOUR, MFW_TIME_FORMAT_24HOUR } T_MFW_TIME_FORMAT; /*SPR 2639, added data structure definition for writing to FFS*/ typedef struct { T_MFW_TIME alarm_time; T_MFW_DATE alarm_date; } T_MFW_ALARM_INFO; /* * TD Parameter */ #define T_MFW_TD_PARA UBYTE /* * Time and date Control Block */ typedef struct { T_MFW_EVENT emask; /* events of interest */ T_MFW_EVENT event; /* current event */ T_MFW_CB handler; T_MFW_TD_PARA para; } T_MFW_TD; /*************************************Events**********************************************/ #define MFW_TD_ALARM 1 /***************************Prototypes**************************************** **/ void mfw_td_init(void); // Initialise time and date on ME switch-on // RAVI T_MFW_HND mfw_td_create(MfwHnd hWin, MfwEvt event, MfwCb cbfunc);//specify MFW event handler MfwRes mfw_td_delete (MfwHnd h);//delete event handler MfwRes mfw_td_set_time(T_MFW_TIME* time);//set the current time MfwRes mfw_td_set_date(T_MFW_DATE* date);//et the current date char* mfw_td_get_clock_str(void); // return clock string (ASCII).Used by MmiIdle // RAVI char* mfw_td_get_date_str(void); // return date string(ASCII) // RAVI T_MFW_DATE* mfw_td_get_date(void);//return date structure .Used by MmiTimeDate // RAVI T_MFW_TIME* mfw_td_get_time(void);//return time structure // RAVI MfwRes mfw_td_set_alarm(T_MFW_TIME* time, T_MFW_DATE* date);//set alarm MfwRes mfw_td_cancel_alarm(void);//cancel alarm // RAVI MfwRes mfw_td_get_alarm(T_MFW_TIME* time, T_MFW_DATE* date);// MmiTimeDate, editing MfwRes mfw_td_set_time_format(T_MFW_TIME_FORMAT format);//set time format /*SPR 2639, added prototype for this function so it can be called from outside the module */ UBYTE mfw_td_convert_to_24_hour(T_MFW_TIME* time);//returns the hour value in 24-hour clock format void mfw_td_exit(void); //kill any data structures // RAVI #endif