FreeCalypso > hg > fc-magnetite

view src/condat3/com/include/cl_list.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c8bd5a927942
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  COMLIB
|  Modul   :  RR/PL
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions of global types used by List Processing functions
|             and the prototypes of those functions: RR/PL layer.
+----------------------------------------------------------------------------- 
*/ 

#ifndef CL_LIST_H
#define CL_LIST_H

/*==== CONST ================================================================*/

#define BITOFFSET_LIST          1024

#define MAX_BYTES_900           16
#define MAX_BYTES_EGSM          23
#define MAX_BYTES_1800          47
#define MAX_BYTES_1900          38
#define MAX_BYTES_DUAL          63
#define MAX_BYTES_850           16
#define MAX_BYTES_DUAL_EGSM     70
#define MAX_BYTES_DUAL_US       54

#define SET_CHANNEL_BIT     0
#define RESET_CHANNEL_BIT   1
#define GET_CHANNEL_BIT     2
#define CHECK_CHANNEL       3


#define T_LIST_MAX_SIZE 128 /* 1024/8 = 128 */
typedef struct
{
  UBYTE                 channels [T_LIST_MAX_SIZE];
} T_LIST;



/*==== MACROS ================================================================*/

#define srv_set_channel(list,ch)    scr_channel_bit(list,ch,SET_CHANNEL_BIT)
#define srv_unset_channel(list,ch)  scr_channel_bit(list,ch,RESET_CHANNEL_BIT)
#define srv_get_channel(list,ch)    scr_channel_bit(list,ch,GET_CHANNEL_BIT)

/*==== VARS =================================================================*/

/*==== TYPES =================================================================*/

/*==== FUNCTIONS ============================================================*/

EXTERN UBYTE  scr_channel_bit             (T_LIST              *list,
                                           int                  channel,
                                           int                  mode);
EXTERN int    srv_create_list             (T_LIST              *list,
                                           USHORT              *channel_array,
                                           USHORT              size,
                                           UBYTE               zero_at_start,
                                           USHORT              start_index);
EXTERN void   srv_clear_list              (T_LIST              *list);
EXTERN void   srv_copy_list               (T_LIST              *target_list,
                                           T_LIST              *source_list,
                                           UBYTE               size);
EXTERN UBYTE  srv_compare_list            (T_LIST              *list1,
                                           T_LIST              *list2);
EXTERN void   srv_merge_list              (T_LIST              *target_list,
                                           T_LIST              *list);
EXTERN void   srv_unmask_list             (T_LIST *target,T_LIST *source);
EXTERN void   srv_trace_freq_in_list      (T_LIST *list);
EXTERN U8     srv_get_region_from_std     (U8 std);
EXTERN U16    srv_count_list              (T_LIST *list);
extern BOOL   srv_is_list_set             (T_LIST *list);

#endif /* #ifndef CL_LIST_H */