FreeCalypso > hg > fc-magnetite

view src/condat3/com/include/rom_tables.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c8bd5a927942
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS
|  Modul   :  DRV_ROM_TABLES
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This Module defines the operator list tables in ROM
+-----------------------------------------------------------------------------
*/

#ifndef ROM_TABLES_H
#define ROM_TABLES_H


/*==== INCLUDES ===================================================*/

/* The swconfig.cfg is genarated file and we are including here to remove
   multiple inclusions in other .c files */

#include "swconfig.cfg"


/* NHK:
 * Once the tables plmn_compressed, plmn_dict_offset and plmn_dict go to ROM, their names below should match corresponding ROM addresses
 * KSR: Moved to g23m\condat\com\src\drivers\rom_tables.c
 */
#ifdef TI_PS_OP_OPN_TAB_ROMBASED
EXTERN const UBYTE *const ptr_plmn_compressed;
EXTERN const USHORT *const ptr_plmn_dict_offset;
EXTERN const UBYTE *const ptr_plmn_dict;
#endif  /* TI_PS_OP_OPN_TAB_ROMBASED */ 

/* Changes for ROM data */
/* NHK:
 * Once the tables chset and gsmToAsciiTable  go to ROM, their names below should match corresponding ROM addresses
 * KSR: Moved to g23m\condat\com\src\drivers\rom_tables.c
 */
#ifdef TI_PS_OP_CNV_TAB_ROMBASED
#define CSCS_CHSET_Chars 256
EXTERN const UBYTE (*const chset)[CSCS_CHSET_Chars];
EXTERN const UBYTE *const gsmToAsciiTable;
EXTERN const UBYTE *const hexVal;
#endif /* TI_PS_OP_CNV_TAB_ROMBASED */

#endif /* #ifndef ROM_TABLES_H */