FreeCalypso > hg > fc-magnetite
view src/condat3/com/include/rtc.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | f3f58412df01 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM (6301) | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Type definitions and function prototypes for the real time clock driver | SPR 1725, re-wrote file for new RTC driver implementation. +----------------------------------------------------------------------------- */ #ifndef DEF_RTC__H #define DEF_RTC__H /*==== INCLUDES ===================================================*/ #include <string.h> #include "typedefs.h" #include "gdi.h" #include "kbd.h" /*==== EXPORT =====================================================*/ /* * type definitions */ typedef enum { RTC_TIME_FORMAT_12HOUR, RTC_TIME_FORMAT_24HOUR } T_RTC_TIME_FORMAT; typedef struct { UBYTE day; UBYTE month; USHORT year; } T_RTC_DATE; typedef struct { UBYTE minute; UBYTE hour; UBYTE second; T_RTC_TIME_FORMAT format; BOOL PM_flag; } T_RTC_TIME; typedef void (*RtcCallback) (void*); /* RTC event handler */ /* * Prototypes */ BOOL rtc_clock_cleared();// wrapper for RTC_RtcReset(); UBYTE rtc_set_time_date(T_RTC_DATE* date, T_RTC_TIME* time); // wrapper for RTC_setTimeDate(); UBYTE rtc_get_time_date(T_RTC_DATE* date, T_RTC_TIME* time); // wrapper for RTC_getTimeDate(); UBYTE rtc_set_alarm(T_RTC_DATE* date , T_RTC_TIME* time, RtcCallback callback_func );//wrapper for RTC_setAlarm(); UBYTE rtc_get_alarm(T_RTC_DATE* date, T_RTC_TIME* time);//wrapper for RTC_getAlarm(); UBYTE rtc_unset_alarm();//wrapper for RTC_UnsetAlarm(); UBYTE rtc_set_time_format(T_RTC_TIME_FORMAT format);//wrapper for RTC_Set12HourMode(); #endif /* #ifndef DEF_RTC_H */