FreeCalypso > hg > fc-magnetite

view src/condat3/com/include/rx.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c8bd5a927942
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM (6301)
|  Modul   :  
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Types definitions for the fieldstrength driver
|             .
+----------------------------------------------------------------------------- 

 $Hist       

    Oct 05, 2006    ER: OMAPS00094496 x0061088(Prachi)
    Description:Enhance RSSI to 3 parameters: Strength, quality, min-access-level
    Solution:In order to provide a more accurate antenna icon on screen, in addition to "signal strength" the parameters
    "signal quality" and "Min-aces-level" are required. 

*/ 

#ifndef RX_H
#define RX_H

/*
 * Signal Values
 */
#define RX_QUAL_UNAVAILABLE   0xFF /* should be kept identically   */ 
                                   /* with the value defined in RR */
#ifdef FF_PS_RSSI
#define RX_ACCE_UNAVAILABLE   0xFF
#endif

/*
 * Signal Types
 */
#define RX_SIGTYPE_RXLEVEL    0

/*
 * Status Type
 */
typedef struct rx_Status_Type
{
  UBYTE actLevel;
  UBYTE gsmLevel;
  UBYTE rxQuality;
#ifdef FF_PS_RSSI
  UBYTE min_access_level;
#endif
} rx_Status_Type;

/*
 * Driver Control Block
 */
typedef struct rx_DCB_Type
{
  UBYTE    Steps;
} rx_DCB_Type;

#if defined (NEW_FRAME)
/*
 * to achieve backward compatibility with older definitions
 */
#define drv_SignalCB_Type           T_DRV_CB_FUNC
#define drv_SignalID_Type           T_DRV_SIGNAL
#define T_VSI_THANDLE               USHORT
#endif
/*
 * Prototypes
 */
EXTERN UBYTE rx_Init        (drv_SignalCB_Type   in_SignalCBPtr);
EXTERN void  rx_Exit        (void);
EXTERN UBYTE rx_SetConfig   (rx_DCB_Type       * in_DCBPtr);
EXTERN UBYTE rx_GetConfig   (rx_DCB_Type       * out_DCBPtr);
EXTERN UBYTE rx_GetStatus   (rx_Status_Type    * out_StatusPtr);
EXTERN void  rx_timeout     (T_VSI_THANDLE       rx_handle);
#endif