FreeCalypso > hg > fc-magnetite
view src/cs/drivers/drv_core/timer/timer2.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 945cf7f506b2 |
children |
line wrap: on
line source
/****************************************************************************** TEXAS INSTRUMENTS INCORPORATED PROPRIETARY INFORMATION Property of Texas Instruments -- For Unrestricted Internal Use Only Unauthorized reproduction and/or distribution is strictly prohibited. This product is protected under copyright law and trade secret law as an unpublished work. Created 1987, (C) Copyright 1997 Texas Instruments. All rights reserved. Filename : timer2.c Description : Set of useful functions for TIMER module test cases Project : drivers Author : pmonteil@tif.ti.com Patrice Monteil. Version number : 1.3 Date and time : 08/18/00 14:42:39 Previous delta : 07/10/00 16:15:18 SCCS file : /db/gsm_asp/db_ht96/dsp_0/gsw/rel_0/mcu_l1/release_gprs/RELEASE_GPRS/drivers1/common/SCCS/s.timer2.c Sccs Id (SID) : '@(#) timer2.c 1.3 08/18/00 14:42:39 ' *****************************************************************************/ #include "l1sw.cfg" #if (OP_L1_STANDALONE == 0) #include "main/sys_types.h" #else #include "sys_types.h" #endif #include "memif/mem.h" #include "timer2.h" /*--------------------------------------------------------------*/ /* Dtimer2_Get_cntlreg() */ /*--------------------------------------------------------------*/ /* Parameters : none */ /* Return : none */ /* Functionality : read one of the TIMER register */ /*--------------------------------------------------------------*/ SYS_UWORD16 Dtimer2_Get_cntlreg(void) { volatile SYS_UWORD16 timerReg; timerReg = (( * (SYS_UWORD16 *) D_TIMER_CNTL) & D_TIMER_CNTL_MASK); return(timerReg); } /*--------------------------------------------------------------*/ /* Dtimer2_Init_cntl() */ /*--------------------------------------------------------------*/ /* Parameters :start/stop,reload yes/no,pre scale,ext clk on/off*/ /* Return : none */ /* Functionality : initialize the timer start, autoreload, Ptv */ /* and clock enable */ /*--------------------------------------------------------------*/ void Dtimer2_Init_cntl (SYS_UWORD16 St, SYS_UWORD16 Reload, SYS_UWORD16 clockScale, SYS_UWORD16 clkon) { SYS_UWORD16 cntl = * (SYS_UWORD16 *) D_TIMER_CNTL; cntl &= ~(D_TIMER_ST | D_TIMER_PTV); /* stop and reset values */ (Reload) ? (cntl |= D_TIMER_AR) : (cntl &= ~D_TIMER_AR); cntl |= (clockScale << 2 ); cntl |= ( clkon << 5 ); * (SYS_UWORD16 *) D_TIMER_LOAD = St; * (SYS_UWORD16 *) D_TIMER_CNTL = cntl; } /*--------------------------------------------------------------*/ /* Dtimer2_AR() */ /*--------------------------------------------------------------*/ /* Parameters :start/stop,reload yes/no,pre scale,ext clk on/off*/ /* Return : none */ /* Functionality : set the AR bit Ar = 0 | 1 */ /*--------------------------------------------------------------*/ void Dtimer2_AR(SYS_UWORD16 Ar) { SYS_UWORD16 cntl = * (SYS_UWORD16 *) D_TIMER_CNTL; cntl &= ~(D_TIMER_ST); /* stop the timer */ cntl &= ~(D_TIMER_AR); cntl |= ( Ar << 1 ); * (SYS_UWORD16 *) D_TIMER_CNTL = cntl; } /*--------------------------------------------------------------*/ /* Dtimer2_PTV() */ /*--------------------------------------------------------------*/ /* Parameters : pre scale */ /* Return : none */ /* Functionality : set the Ptv bits Ptv = 0 => 7 */ /*--------------------------------------------------------------*/ void Dtimer2_PTV(SYS_UWORD16 Ptv) { SYS_UWORD16 cntl = * (SYS_UWORD16 *) D_TIMER_CNTL; cntl &= ~(D_TIMER_ST); /* stop the timer */ cntl &= ~(D_TIMER_PTV); /* Ptv[4:0] set to 0 */ cntl |= ( Ptv << 2 ); * (SYS_UWORD16 *) D_TIMER_CNTL = cntl; } /*--------------------------------------------------------------*/ /* Dtimer1_Clken() */ /*--------------------------------------------------------------*/ /* Parameters : ext clk on/off */ /* Return : none */ /* Functionality : set the clock_enable bit En = 0 | 1 */ /*--------------------------------------------------------------*/ void Dtimer2_Clken(SYS_UWORD16 En) { SYS_UWORD16 cntl = * (SYS_UWORD16 *) D_TIMER_CNTL; cntl &= ( ~D_TIMER_CLK_EN); cntl |= ( En << 5 ); * (SYS_UWORD16 *) D_TIMER_CNTL = cntl; } /*--------------------------------------------------------------*/ /* Dtimer2_Start() */ /*--------------------------------------------------------------*/ /* Parameters : on/off */ /* Return : none */ /* Functionality : Start or stop the timer */ /*--------------------------------------------------------------*/ void Dtimer2_Start (SYS_UWORD16 startStop) { (startStop == D_TIMER_ST) ? ((* (SYS_UWORD16 *) D_TIMER_CNTL) |= D_TIMER_ST) : /* condition vrai */ ((* (SYS_UWORD16 *) D_TIMER_CNTL) &= ~D_TIMER_ST); /* condition fausse */ } /*--------------------------------------------------------------*/ /* Dtimer2_ReadValue() */ /*--------------------------------------------------------------*/ /* Parameters : on/off */ /* Return : none */ /* Functionality : Read timer value */ /*--------------------------------------------------------------*/ SYS_UWORD16 Dtimer2_ReadValue (void) { return(* (SYS_UWORD16 *) D_TIMER_READ); } /*--------------------------------------------------------------*/ /* Parameters : on/off */ /* Return : none */ /* Functionality : Write timer value */ /*--------------------------------------------------------------*/ void Dtimer2_WriteValue (SYS_UWORD16 value) { (* (SYS_UWORD16 *) D_TIMER_LOAD) = value; }