src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.

/************* Revision Controle System Header *************
 *                  GSM Layer 1 software
 * L1_DYN_DWL_ERROR.H
 *
 *        Filename l1_dyn_dwl_error.h
 *  Copyright 2004 (C) Texas Instruments
 *
 ************* Revision Controle System Header *************/
#if (L1_DYN_DSP_DWNLD == 1)

#ifndef _L1_DYN_DWL_ERROR_H_
#define _L1_DYN_DWL_ERROR_H_

#define C_DYN_DWL_ERR_NONE           (0x0000)   /* no error */
#define C_DYN_DWL_ERR_WR_PTR         (0x0001)   /* write pointer is not correct */
#define C_DYN_DWL_ERR_SIZE           (0x0002)   /* size is not correct          */
#define C_DYN_DWL_ERR_END_SECTION    (0x0004)   /* end word is not detected     */
#define C_DYN_DWL_ERR_UN_INSTALL     (0x0008)   /* installation or un-installation fail */
#define C_DYN_DWL_ERR_NOT_ENDED      (0x0010)   /* new request received but download not finished */ 

#endif    // _L1_DYN_DWL_ERROR_H_
#endif    // L1_DYN_DSP_DWNLD