FreeCalypso > hg > fc-magnetite
view src/cs/layer1/hmacs/macs_def.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/************* Revision Control System Header ************* * GSM Layer 1 software * MACS_DEF.H * * Filename macs_def.h * Copyright 2003 (C) Texas Instruments * ************* Revision Control System Header *************/ /*********************************************************/ /* Type definition for MAC-S static variables */ /*********************************************************/ /*---------------------------------------------------*/ /* MAC-S static parameters */ /*---------------------------------------------------*/ typedef struct { /* General TBF parameters processed by MAC-S */ /*********************************************/ UWORD8 old_synchro_ts; // Synchro timeslot when data was received on the slots indicated in last_rx_allocation // Dynamic allocation mode parameters UWORD8 first_monitored_ts; // First Tx slot allocated by the network UWORD8 last_monitored_ts; // Last Tx slot allocated by the network // Fixed allocation mode parameters UWORD8 dl_ctrl_ts_mask; // Mask used to verify if conditions are met to map the downlink control timeslot UWORD32 sti_block_id; // Block ID of the starting time /* Ressources allocated by MAC-S */ /*********************************************/ UWORD8 rx_allocation; // Slots allocated for downlink blocks reception UWORD8 tx_allocation; // Slots allocated for uplink blocks transmission UWORD8 tx_data; // Slots allocated for uplink data block transfer only UWORD8 tx_prach_allocation; // Slots allocated for poll response in PRACH burst format UWORD8 pwr_allocation; // Slots allocated for power measurements UWORD8 last_rx_alloc; // Downlink resources allocated during the last block period /* MAC-S global parameters */ /***************************/ UWORD32 rx_blk_period; // Set to BLOCK_ID if DL blocks were received, FFFFFFFF if no DL blocks UWORD8 rlc_blocks_sent; // Last sent uplink RLC/MAC block ID UWORD8 rx_no; // Number of received blocks to report to RLC UWORD8 last_poll_response; // Status of the poll responses requested by RLC the block period before UWORD8 ul_buffer_index[8]; // UL buffer index table loaded after RLC UL allocation check // Dynamic allocation mode parameters UWORD8 usf_vote_enable; // This bitmap is used to set on which timeslot the DSP USF vote must be enabled UWORD8 usf_good; // Bit set to 1 corresponds to invalid or valid and good USF values UWORD32 next_usf_mon_block[2]; // For each uplink block, memorize the next block_id when the USF will be monitored // Note: for type 1 MS, max. 2 Tx can be done !!! // Fixed allocation mode parameters UWORD8 tra_gap; // Number of free Tx slots at the end of the frame BOOL fix_alloc_exhaust; // Set to 1 if the fixed allocation bitmap has exhausted #if MACS_STATUS BOOL bcch_monitoring; // When MAC-S calls RLC, set to TRUE if BCCH monitoring was done during the frame before #endif } T_MACS_STATIC; /*---------------------------------------------------*/ /* MS Class parameters */ /*---------------------------------------------------*/ typedef struct { UWORD8 rx; UWORD8 tx; UWORD8 sum; UWORD8 tta; UWORD8 ttb; UWORD8 tra; UWORD8 trb; } T_MSCLASS_PARAMETERS;