FreeCalypso > hg > fc-magnetite
view src/cs/layer1/p_include/l1p_sign.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/************* Revision Controle System Header ************* * GSM Layer 1 software * L1P_SIGN.H * * Filename l1p_sign.h * Copyright 2003 (C) Texas Instruments * ************* Revision Controle System Header *************/ #define P_GPRS ( P_L1C + 2 ) // Messages Packet Transfer <-> L1A #define MPHP_SINGLE_BLOCK_REQ ( ( P_GPRS << 8 ) | 1 ) #define MPHP_SINGLE_BLOCK_CON ( ( P_GPRS << 8 ) | 2 ) #define MPHP_STOP_SINGLE_BLOCK_REQ ( ( P_GPRS << 8 ) | 3 ) #define MPHP_STOP_SINGLE_BLOCK_CON ( ( P_GPRS << 8 ) | 4 ) #define L1P_SINGLE_BLOCK_CON ( ( P_GPRS << 8 ) | 5 ) #define MPHP_ASSIGNMENT_REQ ( ( P_GPRS << 8 ) | 6 ) #define MPHP_ASSIGNMENT_CON ( ( P_GPRS << 8 ) | 7 ) #define MPHP_TBF_RELEASE_REQ ( ( P_GPRS << 8 ) | 8 ) #define MPHP_TBF_RELEASE_CON ( ( P_GPRS << 8 ) | 9 ) #define MPHP_REPEAT_UL_FIXED_ALLOC_REQ ( ( P_GPRS << 8 ) | 10 ) #define MPHP_REPEAT_UL_FIXED_ALLOC_CON ( ( P_GPRS << 8 ) | 11 ) #define MPHP_PDCH_RELEASE_REQ ( ( P_GPRS << 8 ) | 12 ) #define MPHP_PDCH_RELEASE_CON ( ( P_GPRS << 8 ) | 13 ) #define MPHP_TIMING_ADVANCE_REQ ( ( P_GPRS << 8 ) | 14 ) #define MPHP_TIMING_ADVANCE_CON ( ( P_GPRS << 8 ) | 15 ) #define MPHP_UPDATE_PSI_PARAM_REQ ( ( P_GPRS << 8 ) | 16 ) #define MPHP_UPDATE_PSI_PARAM_CON ( ( P_GPRS << 8 ) | 17 ) #define MPHP_RA_REQ ( ( P_GPRS << 8 ) | 18 ) #define MPHP_RA_CON ( ( P_GPRS << 8 ) | 19 ) #define MPHP_RA_STOP_REQ ( ( P_GPRS << 8 ) | 20 ) #define MPHP_RA_STOP_CON ( ( P_GPRS << 8 ) | 21 ) #define MPHP_POLLING_RESPONSE_REQ ( ( P_GPRS << 8 ) | 22 ) #define MPHP_POLLING_IND ( ( P_GPRS << 8 ) | 23 ) #define L1P_RA_DONE ( ( P_GPRS << 8 ) | 24 ) // Messages Packet Idle <-> L1A #define MPHP_START_PCCCH_REQ ( ( P_GPRS << 8 ) | 25 ) #define MPHP_STOP_PCCCH_REQ ( ( P_GPRS << 8 ) | 26 ) #define MPHP_STOP_PCCCH_CON ( ( P_GPRS << 8 ) | 27 ) #define MPHP_SCELL_PBCCH_REQ ( ( P_GPRS << 8 ) | 28 ) #define MPHP_SCELL_PBCCH_STOP_REQ ( ( P_GPRS << 8 ) | 29 ) #define MPHP_SCELL_PBCCH_STOP_CON ( ( P_GPRS << 8 ) | 30 ) #define MPHP_CR_MEAS_REQ ( ( P_GPRS << 8 ) | 31 ) #define MPHP_CR_MEAS_STOP_REQ ( ( P_GPRS << 8 ) | 32 ) #define MPHP_CR_MEAS_STOP_CON ( ( P_GPRS << 8 ) | 33 ) #define MPHP_INT_MEAS_REQ ( ( P_GPRS << 8 ) | 34 ) #define MPHP_INT_MEAS_STOP_REQ ( ( P_GPRS << 8 ) | 35 ) #define MPHP_INT_MEAS_STOP_CON ( ( P_GPRS << 8 ) | 36 ) #define MPHP_NCELL_PBCCH_REQ ( ( P_GPRS << 8 ) | 37 ) #define MPHP_NCELL_PBCCH_STOP_REQ ( ( P_GPRS << 8 ) | 38 ) #define MPHP_NCELL_PBCCH_STOP_CON ( ( P_GPRS << 8 ) | 39 ) #define MPHP_DATA_IND ( ( P_GPRS << 8 ) | 40 ) #define MPHP_CR_MEAS_IND ( ( P_GPRS << 8 ) | 41 ) #define MPHP_INT_MEAS_IND ( ( P_GPRS << 8 ) | 42 ) #define MPHP_TINT_MEAS_IND ( ( P_GPRS << 8 ) | 43 ) #define MPHP_NCELL_PBCCH_IND ( ( P_GPRS << 8 ) | 44 ) #define MPHP_TCR_MEAS_REQ ( ( P_GPRS << 8 ) | 45 ) #define MPHP_TCR_MEAS_IND ( ( P_GPRS << 8 ) | 46 ) #define MPHP_TCR_MEAS_STOP_REQ ( ( P_GPRS << 8 ) | 47 ) #define MPHP_TCR_MEAS_STOP_CON ( ( P_GPRS << 8 ) | 48 ) /*** L1S -> L1A communication ***/ #define L1P_PALLC_INFO ( ( P_GPRS << 8) | 49) #define L1P_PNP_INFO ( ( P_GPRS << 8) | 50) #define L1P_PEP_INFO ( ( P_GPRS << 8) | 51) #define L1P_PBCCHS_INFO ( ( P_GPRS << 8) | 52) #define L1P_PACCH_INFO ( ( P_GPRS << 8) | 53) #define L1P_CR_MEAS_DONE ( ( P_GPRS << 8) | 54) #define L1P_TRANSFER_DONE ( ( P_GPRS << 8) | 55) #define L1P_TCR_MEAS_DONE ( ( P_GPRS << 8) | 56) #define L1P_TBF_RELEASED ( ( P_GPRS << 8) | 57) #define L1P_ITMEAS_IND ( ( P_GPRS << 8) | 58) #define L1P_POLL_DONE ( ( P_GPRS << 8) | 59) #define L1P_PDCH_RELEASED ( ( P_GPRS << 8) | 60) #define L1P_TA_CONFIG_DONE ( ( P_GPRS << 8) | 61) #define L1P_PBCCHN_INFO ( ( P_GPRS << 8) | 62) #define L1P_REPEAT_ALLOC_DONE ( ( P_GPRS << 8) | 63) #define L1P_ALLOC_EXHAUST_DONE ( ( P_GPRS << 8) | 64)