FreeCalypso > hg > fc-magnetite

view src/cs/layer1/tm_cust0/l1tm_tpu12.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents b870b6a44d31
children
line wrap: on
line source

/************* Revision Controle System Header *************
 *                  GSM Layer 1 software
 * L1TM_TPU2.C
 *
 *        Filename %M%
 *        Version  %I%
 *        Date     %G%
 * 
 ************* Revision Controle System Header *************/
#include "l1_confg.h"

#if (TESTMODE && (RF==12))

#include "tm_defs.h"
#include "l1_const.h"
#include "l1_types.h"

#include "l1tm_defty.h"
#include "l1tm_cust.h"
#include "l1tm_tpu12.h"

#if (AUDIO_TASK == 1)
  #include "l1audio_const.h"
  #include "l1audio_cust.h"
  #include "l1audio_defty.h"
#endif
////////////////////////////henry
#if (L1_GTT == 1)
  #include "l1gtt_const.h"
  #include "l1gtt_defty.h"
#endif
///////////////////////////  
#include "l1_defty.h"
#include "l1_msgty.h"
#include "l1_tabs.h"

#include "l1tm_msgty.h"
#include "l1tm_varex.h"

#if ((ANLG_FAM == 1) || (ANLG_FAM == 2))
  #include "spi_drv.h"
#endif   

#include "tpudrv12.h"
#include "l1_rf12.h"


#include <string.h>

// Import band configuration from Flash module (need to replace by an access function)


// External function prototypes


void Cust_tm_tpu_table_write        (T_TM_RETURN *tm_return, WORD8 index, UWORD8 size, UWORD8 table[])
{
/*
	INDICES BETWEEN in [0..63] RANGE ARE RESERVED FOR TI RF MODULE
*/

    // fill in the cid
    tm_return->cid = TPU_TABLE_WRITE;

    switch (index)
    {
        default:
          tm_return->size = 0;
          tm_return->status = E_BADINDEX;
          break;
    } // end of switch
}

void Cust_tm_tpu_table_read         (T_TM_RETURN *tm_return, WORD8 index)
{
/*
	INDICES BETWEEN in [0..63] RANGE ARE RESERVED FOR TI RF MODULE
*/

    // fill in the cid
    tm_return->cid = TPU_TABLE_READ;

    switch (index)
    {
        default:
          tm_return->size = 0;
          tm_return->status = E_BADINDEX;
          break;
    } // end of switch
}

#endif //TESTMODE