FreeCalypso > hg > fc-magnetite
view src/cs/layer1/tools/gen_intram.pl @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 22 Jul 2018 06:04:49 +0000 |
parents | 945cf7f506b2 |
children |
line wrap: on
line source
#!/usr/bin/perl if ($#ARGV == -1) { die "\nSyntax is gen_intram <C file (with extension)>\n\n"; } $#ARGV == 0 or die "Incorrect number of parameters"; $c_input_file = @ARGV[0]; # ------------------------------------------------------------------------------- # Remove .c extension and create the new filename for the processed file @file_name = split /\.c/, $c_input_file; $c_output_file = join ('', @file_name, "_intram.c"); print "Output file: $c_output_file\n"; # ------------------------------------------------------------------------------- # Generates the C file for internal RAM open input_stream, $c_input_file or die "\n\n Input C file $C_input_file cannot be opened: $!\n"; open(output_stream,'>'.$c_output_file) or die "\n\nCan't open output file $C_output_file: $!"; printf output_stream "/* ----- WARNING - File automatically generated - Do not modify it ----- */\n\n\n\n\n"; $d_internal_found = 0; # Search for data while(<input_stream>) { chomp $_; # Search for start comment if ( /#pragma DUPLICATE_FOR_INTERNAL_RAM_START/ ) { # DEBUG #print "Found begin of string\n"; $d_internal_found = 1; # Found begin internal RAM code, then output up to the end string while(<input_stream>) { chomp $_; if ( /#pragma DUPLICATE_FOR_INTERNAL_RAM_END/ ) { # Found end of the internal RAM code, then search for another one # DEBUG #print "Found end of string\n"; last; } else { printf output_stream "%s\n", $_; # DEBUG #print "Copied lines - $_\n"; } } } } close input_stream; close output_stream;