view src/cs/layer1/tools/make_cmd.pl @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

#!perl

# generate a dynamic Linker command file 
# PARAMETER ARE:
# 1 : Name of the Linker command file
# 2 : Name of the file with the parameter
# 

my ($cmd_file_temp,$tmp_file)=@ARGV;

open (TMP, "$tmp_file");
my $const_boot_lib = <TMP>;
my $bss_boot_lib = <TMP>;
my $bss_libs = <TMP>;
my $const_libs = <TMP>;
my $toolchoice_type = <TMP>;
close TMP;

# define the REPLACE STRINGS
my $const_boot_str="(CONST_BOOT_LIB)";
my $bss_boot_str="(BSS_BOOT_LIB)";
my $bss_str="(BSS_LIBS)";
my $const_str="(CONST_LIBS)";

# define some local variables
my $temp;
my @CMD;
my $line;

# determine the cmd file name
@CMD=split /.template/, $cmd_file_temp;
$cmd_file=$CMD[0].".cmd";

open (TMP1, ">$cmd_file");
open (TMP,$cmd_file_temp);
while ($line=<TMP>) {
	if ($line =~ m/$const_boot_str/g) {
		$line=mak_libs ($const_boot_lib)
	}
	if ($line =~ m/$bss_boot_str/g) {
		$line=mak_libs ($bss_boot_lib)
	}
	if ($line =~ m/$bss_str/g) {
		# insert the Libs
		$line=mak_libs ($bss_libs);
	}
	if ($line =~ m/$const_str/g) {
		$line=mak_libs ($const_libs)
	}

    # NEW COMPILER MANAGEMENT 
    # If use of VISUAL LINKER, needs to manage trampoline download.
    # Case of:
    #      - TOOL_CHOICE == 0 => compiler v1.22e with vlinker v1.9902
    if ($toolchoice_type == 0)  {
        $line =~ s(COMMENT2START)();
        $line =~ s(COMMENT2END)();    
    }
     
    if ($toolchoice_type == 3)  {
        $line =~ s(COMMENT2START)(/*);
        $line =~ s(COMMENT2END)(*/);
    }

	print TMP1 $line;
}
close TMP;
close TMP1;
unlink $tmp_file;

sub mak_libs
{
	my ($bss_libs) =@_;
	my @temp;
	@temp = split /=/, $bss_libs;
	$_="\t\t\t" . $temp[1];
	s/\) /)\n\t\t\t/g;
	$_ =~ tr /\"//d;
	return $_;
}