FreeCalypso > hg > fc-magnetite

view src/cs/riviera/rv/rv_trace.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/************************************************************************************* 
 *																			         * 
 *  Name        rv_trace.h													         * 
 *																			         * 
 *  Function    this file contains trace definitions for basic layers		         * 
 *																			         * 
 *  Date        Modification                                                         * 
 *  ------------------------												         * 
 *  10/12/00	 - Create Cristian Livadiotti - c-livadiotti@ti.com			         * 
 *																			         * 
 *																			         * 
 * (C) Copyright 1999 by Texas Instruments Incorporated, All Rights Reserved         * 
 *                                                                                   *
 * --------------------------------------------------------------------------------- *
 *                                                                                   *
 *   History:                                                                        *
 *                                                                                   *
 *   10/18/2001 - Updated for R2D by Christophe Favergeon		                     * 
 *                                                                                   *
 *************************************************************************************/

#ifndef _RV_TRACE_H_
#define _RV_TRACE_H_



/* Define trace levels.                                                          */
#define RV_TRACE_LEVEL_ERROR		(1)		/* Error condition trace messages.   */
											/* Used when an unrecoverable error is found */
#define RV_TRACE_LEVEL_WARNING		(2)		/* Warning condition trace messages. */
											/* Used when an error is found but is handled properly by the code*/
#define RV_TRACE_LEVEL_DEBUG_HIGH	(3)		/* Debug messages (high debugging).  */
                                            /* high = important debug message */
#define RV_TRACE_LEVEL_DEBUG_MEDIUM	(4)		/* Debug messages.                   */
#define RV_TRACE_LEVEL_DEBUG_LOW	(5)		/* Debug messages (low debugging).   */
                                            /* low = not important debug message */

/* temporary definition of this old flag for backward compatibility */
#define TRACE_RVTEST				(0x001E0004)

#endif /* _RV_GENERAL_H_*/