FreeCalypso > hg > fc-magnetite

view src/cs/riviera/rvt/rvt_env_i.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/*******************************************************************************
 *
 * rvt_env_i.h
 *
 * This file should be included by rvt_env.c ONLY!!!
 * It includes definitions of global variables used for trace.
 *
 * (C) Texas Instruments, all rights reserved
 *
 * Version number	: 0.11
 *
 * History			: 0.1  (7/4/2000) - Created
 *       			: 0.11 (6/13/2002) - Remove useless dependency.
 *
 * Date             : 6/13/2002
 *
 * Author           : Cristian Livadiotti, c-livadiotti@ti.com
 *
 ******************************************************************************/

#ifndef __RVT_ENV_I_H__
#define __RVT_ENV_I_H__


/*
** Environment global variables
*/
extern T_RVF_MB_ID    rvt_mb_id;
extern T_RVF_ADDR_ID  rvt_addr_id;


/*
** Trace Module State
*/
extern T_RVT_STATE    rvt_module_state;

extern char           *p_rvt_lost_msg;
extern char           *p_rvt_sys_time;
extern T_RVT_USER_DB  rvt_user_db [];
extern T_RVT_USER_ID  rv_trace_user_id;

#define RVT_LOST_MSG              ("RVT: Lost Message ")
#define RVT_LOST_MSG_LENGTH       (sizeof (RVT_LOST_MSG) - 1)

#define RVT_SYS_TIME              ("RVT: System Time ")
#define RVT_SYS_TIME_LENGTH       (sizeof (RVT_SYS_TIME) - 1)

#define RVT_HEX_VALUE_LENGTH      (sizeof ("00000000") - 1)

#ifndef FRAMING_PROTOCOL
	#define RVT_HYPERTERM_LENGTH  (sizeof ('\n') + sizeof ('\r'))
#else
	#define RVT_HDR_LENGTH        (6)
#endif

#endif