FreeCalypso > hg > fc-magnetite

view src/cs/services/Audio/audio_compatibilities.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  File Name:  audio_compatibilities.h                                     */
/*                                                                          */
/*  Purpose:  This file contains the compatibilities table between the      */
/*            audio feature as describe in the S916 specification (annex)   */
/*                                                                          */
/*  Version   0.1                                                           */
/*                                                                          */
/*  Date         Modification                                               */
/*  ------------------------------------                                    */
/*  12 November 2001  Create                                                */
/*                                                                          */
/*  Author       Francois Mazard                                            */
/*                                                                          */
/* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/

#include "rv/rv_defined_swe.h"
#ifdef RVM_AUDIO_MAIN_SWE

  #ifndef __AUDIO_COMPATIBILITIES_H_
    #define __AUDIO_COMPATIBILITIES_H_

    #ifdef __cplusplus
      extern "C"
        {
    #endif

        /* Define the number of audio features */
        #define AUDIO_NUMBER_OF_FEATURES        (13)

        typedef struct {
          BOOLEAN feature[AUDIO_NUMBER_OF_FEATURES];
        } T_AUDIO_ACTIVE_FEATURE;

        /* Define the list of the audio features */
        #define AUDIO_KEYBEEP_FEATURE           (0)
        #define AUDIO_TONES_FEATURE             (1)
        #define AUDIO_MELODY_E1_FEATURE         (2)
        #define AUDIO_VOICE_MEMO_PLAY_FEATURE   (3)
        #define AUDIO_VOICE_MEMO_RECORD_FEATURE (4)
        #define AUDIO_SR_ENROLL_FEATURE         (5)
        #define AUDIO_SR_UPDATE_FEATURE         (6)
        #define AUDIO_SR_RECO_FEATURE           (7)
        #define AUDIO_MELODY_E2_FEATURE         (8)
        #define AUDIO_TTY_FEATURE               (9)
        #define AUDIO_VOICE_MEMO_AMR_PLAY_FEATURE   (10)
        #define AUDIO_VOICE_MEMO_AMR_RECORD_FEATURE (11)
        #define AUDIO_MIDI_FEATURE              (12)

        /* It isn't a starting message */
        #define AUDIO_NO_START_MESSAGE      (-1)

        typedef struct {
          BOOLEAN compatibilities_flag[AUDIO_NUMBER_OF_FEATURES];
        } T_AUDIO_COMPATIBILITES;

    #ifdef __cplusplus
      } 
    #endif

  #endif /* __AUDIO_COMPATIBILITIES_H_ */
#endif /* #ifdef RVM_AUDIO_MAIN_SWE */