FreeCalypso > hg > fc-magnetite

view src/cs/services/Audio/audio_keybeep.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  File Name:  audio_keybeep.c                                             */
/*                                                                          */
/*  Purpose:  This file contains all the functions used to manage the       */
/*            keybeep.                                                      */
/*                                                                          */
/*  Version   0.1                                                           */
/*                                                                          */
/*  Date        Modification                                                */
/*  ------------------------------------                                    */
/*  18 May 2001 Create                                                      */
/*                                                                          */
/*  Author                                                                  */
/*     Francois Mazard - Stephanie Gerthoux                                 */
/*                                                                          */
/* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/

#include "rv/rv_defined_swe.h"
#ifdef RVM_AUDIO_MAIN_SWE
  #ifndef _WINDOWS
    #include "config/swconfig.cfg"
    #include "config/sys.cfg"
    #include "config/chipset.cfg"
  #endif

  #include <math.h>

  /* include the usefull L1 header */
  #include "l1_confg.h"

  #if (KEYBEEP)
  #include "rv/rv_general.h"
  #include "rvm/rvm_gen.h"
  #include "audio/audio_features_i.h"
  #include "audio/audio_ffs_i.h"
  #include "audio/audio_api.h"
  #include "audio/audio_structs_i.h"
  #include "audio/audio_var_i.h"
  #include "audio/audio_messages_i.h"
  #include "rvf/rvf_target.h"
  #include "audio/audio_const_i.h"
  #include "audio/audio_error_hdlr_i.h"

  /* include the usefull L1 header */
  #define BOOL_FLAG
  #define CHAR_FLAG
  #include "l1_types.h"
  #include "l1audio_cust.h"
  #include "l1audio_msgty.h"
  #include "l1audio_signa.h"


  /********************************************************************************/
  /*                                                                              */
  /*    Function Name:   audio_keybeep_convert_parameter                          */
  /*                                                                              */
  /*    Purpose:  Convert the keybeep paramters from the entity to the l1         */
  /*              parameters                                                      */
  /*                                                                              */
  /*    Input Parameters:                                                         */
  /*        entity keybeep message                                                */
  /*                                                                              */
  /*    Output Parameters:                                                        */
  /*        layer 1  keybeep message                                              */
  /*                                                                              */
  /*    Note:                                                                     */
  /*        None.                                                                 */
  /*                                                                              */
  /*    Revision History:                                                         */
  /*        None.                                                                 */
  /*                                                                              */
  /********************************************************************************/


  void audio_keybeep_convert_parameter( T_AUDIO_KEYBEEP_START *entity_parameter,
                                        T_MMI_KEYBEEP_REQ *l1_parameter)
  {
    double frequency_index, frequency_beep, amplitude_beep, amplitude, amplitude_index;

    /* Calculation of the frequency index */
    /* note: we /* add +0.5 to compensate the truncation */
    frequency_beep = (double)(entity_parameter->keybeep_parameter.frequency_beep[0]);
    frequency_index = (256 * cos(6.283185*(frequency_beep/8000)));
    /* Calculation of the amplitude index */
    /* note: we /* add +0.5 to compensate the truncation */
    amplitude_beep = (double)(entity_parameter->keybeep_parameter.amplitude_beep[0]);
    amplitude      = exp((amplitude_beep*0.115129)+(5.544625));
    amplitude_index = amplitude * sin(6.283185*(frequency_beep/8000));

    l1_parameter->d_k_x1_kt0 = (UINT16)((((UINT16)(frequency_index))<<8) | ((UINT16)(amplitude_index)));

    /* Calculation of the frequency index */
    /* note: we /* add +0.5 to compensate the truncation */
    frequency_beep = (double)(entity_parameter->keybeep_parameter.frequency_beep[1]);
    frequency_index = (256 * cos(6.283185*(frequency_beep/8000)));
    /* Calculation of the amplitude index */
    /* note: we /* add +0.5 to compensate the truncation */
    amplitude_beep = (double)(entity_parameter->keybeep_parameter.amplitude_beep[1]);
    amplitude      = exp((amplitude_beep*0.115129)+(5.544625));
    amplitude_index = amplitude * sin(6.283185*(frequency_beep/8000));

    l1_parameter->d_k_x1_kt1 = (UINT16)((((UINT16)(frequency_index))<<8) | ((UINT16)(amplitude_index)));

    l1_parameter->d_dur_kb = (UINT16)(entity_parameter->keybeep_parameter.duration/20);
  }


  /********************************************************************************/
  /*                                                                              */
  /*    Function Name:   audio_keybeep_send_status                                */
  /*                                                                              */
  /*    Purpose:  This function sends the keybeep status to the entity.           */
  /*                                                                              */
  /*    Input Parameters:                                                         */
  /*        status,                                                               */
  /*        return path                                                           */
  /*                                                                              */
  /*    Output Parameters:                                                        */
  /*        None.                                                                 */
  /*                                                                              */
  /*    Note:                                                                     */
  /*        None.                                                                 */
  /*                                                                              */
  /*    Revision History:                                                         */
  /*        None.                                                                 */
  /*                                                                              */
  /********************************************************************************/
  void audio_keybeep_send_status (T_AUDIO_RET status, T_RV_RETURN return_path)
  {
    void *p_send_message = NULL;
    T_RVF_MB_STATUS mb_status = RVF_RED;

    while (mb_status == RVF_RED)
    {
      /* allocate the message buffer */
      mb_status = rvf_get_buf (p_audio_gbl_var->mb_external,
                               sizeof (T_AUDIO_KEYBEEP_STATUS),
                               (T_RVF_BUFFER **) (&p_send_message));

      /* If insufficient resources, then report a memory error and abort.               */
      /* and wait until more ressource is given */
      if (mb_status == RVF_RED)
      {
        audio_keybeep_error_trace(AUDIO_ENTITY_NO_MEMORY);
        rvf_delay(RVF_MS_TO_TICKS(1000));
      }
    }
    /*fill the header of the message */
        ((T_AUDIO_KEYBEEP_STATUS *)(p_send_message))->os_hdr.msg_id = AUDIO_KEYBEEP_STATUS_MSG;

    /* fill the status parameters */
    ((T_AUDIO_KEYBEEP_STATUS *)(p_send_message))->status = status;

    if (return_path.callback_func == NULL)
    {
      /* send the message to the entity */
      rvf_send_msg (return_path.addr_id,
                    p_send_message);
    }
    else
    {
      /* call the callback function */
      (*return_path.callback_func)((void *)(p_send_message));
      rvf_free_buf((T_RVF_BUFFER *)p_send_message);
    }
  }
  /********************************************************************************/
  /*                                                                              */
  /*    Function Name:   audio_keybeep_manager                                    */
  /*                                                                              */
  /*    Purpose:  This function is called to manage a key beep generation         */
  /*              and DTMF generation.                                            */
  /*                                                                              */
  /*    Input Parameters:                                                         */
  /*        Audio Key Beep Parameters,                                            */
  /*                                                                              */
  /*    Output Parameters:                                                        */
  /*        None.                                                                 */
  /*                                                                              */
  /*    Note:                                                                     */
  /*        None.                                                                 */
  /*                                                                              */
  /*    Revision History:                                                         */
  /*        None.                                                                 */
  /*                                                                              */
  /********************************************************************************/
  void audio_keybeep_manager (T_RV_HDR *p_message)
  {
    /* Declare local variables.                                                   */
    void *p_send_message;

    /**************** audio_keybeep_manager function begins *********************/
    switch(p_audio_gbl_var->keybeep.state)
    {
      case AUDIO_KEYBEEP_IDLE:
        {
          switch(p_message->msg_id)
          {
             case AUDIO_KEYBEEP_START_REQ:
              {
                /* save the addr id of the entity */
                p_audio_gbl_var->keybeep.task_id = p_message->src_addr_id;

                /* save the return path */
                p_audio_gbl_var->keybeep.return_path.callback_func = ((T_AUDIO_KEYBEEP_START*)(p_message))->return_path.callback_func;
                p_audio_gbl_var->keybeep.return_path.addr_id       = ((T_AUDIO_KEYBEEP_START*)(p_message))->return_path.addr_id;


                /* allocate the buffer for the message to the L1 */
                p_send_message = audio_allocate_l1_message(sizeof(T_MMI_KEYBEEP_REQ));
                if ( p_send_message != NULL)
                {
                  /* Convert the entity parameters to the audio L1 parameters */
                  audio_keybeep_convert_parameter((T_AUDIO_KEYBEEP_START *)p_message,
                                                  (T_MMI_KEYBEEP_REQ *)p_send_message);

                  /* send the start command to the audio L1 */
                  audio_send_l1_message(MMI_KEYBEEP_START_REQ, p_send_message);
                }

                /* change to the state AUDIO_KEYBEEP_WAIT_START_CONFIRMATION */
                p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_WAIT_START_CON;
               break;
               }

             case AUDIO_KEYBEEP_STOP_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_STOP *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_STOP_EVENT);
                break;
              }
          }
        break;
        } /* case AUDIO_KEYBEEP_IDLE */

      case AUDIO_KEYBEEP_WAIT_START_CON:
        {
          switch(p_message->msg_id)
          {
             case MMI_KEYBEEP_START_CON:
              {
                /* change to the state AUDIO_KEYBEEP_WAIT_STOP_COMMAND */
                p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_WAIT_STOP_COMMAND;
              break;
              }
             case AUDIO_KEYBEEP_STOP_REQ:
               /*.Before stopping this task, control that                           */
               /*          stop task id caller = Keybeep task id                    */
               {
                 if ( p_audio_gbl_var->keybeep.task_id == p_message->src_addr_id)
                 {
                    /* change to the state AUDIO_KEYBEEP_WAIT_STOP_CONFIRMATION */
                    p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_WAIT_START_CON_TO_STOP;
                 }
                 else
                 {
                   /* A stop request from an other task is sent during a start connection */
                   /* event error - send an error message  */
                   audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_STOP *)(p_message))->return_path);

                   audio_keybeep_error_trace(AUDIO_ERROR_STOP_EVENT);
                 }
              break;
              }
            case AUDIO_KEYBEEP_START_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_START *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_START_EVENT);
              break;
              }
          }
        break;
        } /* case AUDIO_WAIT_START_CON */

       case AUDIO_KEYBEEP_WAIT_START_CON_TO_STOP:
        {
          switch(p_message->msg_id)
          {
             case MMI_KEYBEEP_START_CON:
              {
                /* send the stop command to the audio L1 */
                /* allocate the buffer for the message to the L1 */
                p_send_message = audio_allocate_l1_message(0);
                if ( p_send_message != NULL)
                {
                  /* send the start command to the audio L1 */
                  audio_send_l1_message(MMI_KEYBEEP_STOP_REQ, p_send_message);
                }

                /* change to the state AUDIO_KEYBEEP_WAIT_STOP_CON */
                p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_WAIT_STOP_CON;
               break;
               }
              case AUDIO_KEYBEEP_START_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_START *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_START_EVENT);
              break;
              }
              case AUDIO_KEYBEEP_STOP_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_STOP *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_STOP_EVENT);
              break;
              }
          }
        break;
        }

       case AUDIO_KEYBEEP_WAIT_STOP_COMMAND:
        {
          switch(p_message->msg_id)
          {
             case MMI_KEYBEEP_STOP_CON:
              {
                audio_keybeep_send_status (AUDIO_OK, p_audio_gbl_var->keybeep.return_path);

                /* change to the state AUDIO_KEYBEEP_IDLE */
                p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_IDLE;
               break;
              }

             case AUDIO_KEYBEEP_STOP_REQ:
               /* A stop request is sent during a stop connection                        */
               /* Save the addr id of the entity */
               p_audio_gbl_var->keybeep.task_id = p_message->src_addr_id;

               /*.Control that (stop task id caller = Keybeep task id) and stop the task */
               { if ( p_audio_gbl_var->keybeep.task_id == p_message->src_addr_id)
                  {

                    /* send the stop command to the audio L1 */
                    /* allocate the buffer for the message to the L1 */
                    p_send_message = audio_allocate_l1_message(0);
                    if (p_send_message != NULL)
                    {
                      /* send the start command to the audio L1 */
                      audio_send_l1_message(MMI_KEYBEEP_STOP_REQ, p_send_message);
                    }

                    /* change to the state AUDIO_KEYBEEP_WAIT_STOP_CONFIRMATION */
                     p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_WAIT_STOP_CON;
                  }
                 else
                 {
                   /* A stop request from an other task is sent during a stop connection */
                   /* event error - send an error message  */
                   audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_STOP *)(p_message))->return_path);

                   audio_keybeep_error_trace(AUDIO_ERROR_STOP_EVENT);
                 }
              break;
              }

            case AUDIO_KEYBEEP_START_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_START *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_START_EVENT);
              break;
              }
          }
        break;
        } /* case AUDIO_KEYBEEP_WAIT_STOP_COMMAND */

        case AUDIO_KEYBEEP_WAIT_STOP_CON:
        {
          switch(p_message->msg_id)
          {
             case MMI_KEYBEEP_STOP_CON:
              {
                audio_keybeep_send_status (AUDIO_OK, p_audio_gbl_var->keybeep.return_path);

                /* change to the state AUDIO_KEYBEEP_IDLE */
                 p_audio_gbl_var->keybeep.state = AUDIO_KEYBEEP_IDLE;
               break;
               }
             case AUDIO_KEYBEEP_STOP_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_STOP *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_STOP_EVENT);
              break;
              }
            case AUDIO_KEYBEEP_START_REQ:
              {
                /* event error - send an error message*/
                audio_keybeep_send_status (AUDIO_ERROR, ((T_AUDIO_KEYBEEP_START *)(p_message))->return_path);

                audio_keybeep_error_trace(AUDIO_ERROR_START_EVENT);
              break;
              }
          }
        break;
        } /* case AUDIO_KEYBEEP_WAIT_STOP_CON */

    } /* switch(p_audio_gbl_var->keybeep.state) */
  } /*********************** End of audio_keybeep_manager function **********************/
  #endif /*  #if (KEYBEEP) */

#endif /* #ifdef RVM_AUDIO_MAIN_SWE */