FreeCalypso > hg > fc-magnetite

view src/cs/services/Audio/audio_vm_amr.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  File Name:  audio_vm_amr.c		                                        */
/*                                                                          */
/*  Purpose:  This file contains all the functions used to manage the       */
/*            Voice Memorization AMR.                                       */
/*                                                                          */
/*  Version   0.1                                                           */
/*                                                                          */
/*  Date        Modification                                                */
/*  ------------------------------------                                    */
/*  2 November 2002 Create                                                  */
/*                                                                          */
/*  Author                                                                  */
/*     Frederic Turgis                                                      */
/*                                                                          */
/* (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/

#include "rv/rv_defined_swe.h"
#ifdef RVM_AUDIO_MAIN_SWE
#ifndef _WINDOWS
    #include "config/swconfig.cfg"
    #include "config/sys.cfg"
    #include "config/chipset.cfg"
  #endif

  /* include the usefull L1 header */
  #include "l1_confg.h"

#if (L1_VOICE_MEMO_AMR)
  #include "rv/rv_general.h"
  #include "rvm/rvm_gen.h"
  #include "audio/audio_features_i.h"
  #include "audio/audio_ffs_i.h"
  #include "audio/audio_api.h"
  #include "audio/audio_structs_i.h"
  #include "audio/audio_var_i.h"
  #include "audio/audio_messages_i.h"
  #include "rvf/rvf_target.h"
  #include "audio/audio_const_i.h"
  #include "audio/audio_error_hdlr_i.h"

  /* include the usefull L1 header */
  #define BOOL_FLAG
  #define CHAR_FLAG
  #include "l1_types.h"
  #include "l1audio_cust.h"
  #include "l1audio_msgty.h"
  #include "l1audio_signa.h"

  /********************************************************************************/
  /*                                                                              */
  /*    Function Name:   audio_voice_memo_amr_message_switch	                  */
  /*                                                                              */
  /*    Purpose:  Manage the message supply between the voice memo play and the   */
  /*              voice memo record AMR                                           */
  /*                                                                              */
  /*    Input Parameters:                                                         */
  /*        start or stop message from the voice memo features                    */
  /*                                                                              */
  /*    Output Parameters:                                                        */
  /*        index of the manager                                                  */
  /*                                                                              */
  /*    Note:                                                                     */
  /*        None.                                                                 */
  /*                                                                              */
  /*    Revision History:                                                         */
  /*        None.                                                                 */
  /*                                                                              */
  /********************************************************************************/
#if (AUDIO_MEM_MANAGER)
  UINT8 audio_voice_memo_amr_memory_message_switch (T_RV_HDR *p_message)
  {
    switch (p_message->msg_id)
    {
    #if(AUDIO_NEW_FFS_MANAGER)
      case AUDIO_VM_AMR_RECORD_TO_FFS_START_REQ:
      case AUDIO_VM_AMR_RECORD_TO_FFS_STOP_REQ:
      {
        return(AUDIO_VM_AMR_RECORD);
      }
      break;
    #endif
    #if(AUDIO_RAM_MANAGER)
      case AUDIO_VM_AMR_RECORD_TO_RAM_START_REQ:
      case AUDIO_VM_AMR_RECORD_TO_RAM_STOP_REQ:
      {
        return(AUDIO_VM_AMR_RECORD);
      }
      break;
    #endif
    #if (AUDIO_NEW_FFS_MANAGER)
      case AUDIO_VM_AMR_PLAY_FROM_FFS_START_REQ:
      case AUDIO_VM_AMR_PLAY_FROM_FFS_STOP_REQ:
      {
        return(AUDIO_VM_AMR_PLAY);
      }
      break;
    #endif
    #if (AUDIO_RAM_MANAGER)
      case AUDIO_VM_AMR_PLAY_FROM_RAM_START_REQ:
      case AUDIO_VM_AMR_PLAY_FROM_RAM_STOP_REQ:
      {
        return(AUDIO_VM_AMR_PLAY);
      }
      break;
    #endif
    #if (AUDIO_MEM_MANAGER)
      /* check channel_id is the one given by driver initialization*/
      case AUDIO_MEM_STATUS_MSG:
      {
        /* check VM AMR is active for the given channel_id */
        if ((p_audio_gbl_var->audio_vm_amr_record.state != AUDIO_IDLE) &&
            ( ((T_AUDIO_MEM_STATUS *)p_message)->channel_id == p_audio_gbl_var->audio_vm_amr_record.channel_id))
          return(AUDIO_VM_AMR_RECORD);

        if ((p_audio_gbl_var->audio_vm_amr_play.state != AUDIO_IDLE) &&
            ( ((T_AUDIO_MEM_STATUS *)p_message)->channel_id == p_audio_gbl_var->audio_vm_amr_play.channel_id))
          return(AUDIO_VM_AMR_PLAY);

        return(AUDIO_VM_AMR_NONE);
      }
      break;
    #endif
      /* driver init => check session_id is VM AMR */
      case AUDIO_DRIVER_INIT_STATUS_MSG:
      {
        UINT8 session_id = ((T_AUDIO_DRIVER_INIT_STATUS *)p_message)->session_id;

        /* session_id is VM AMR */
        if ( (session_id == AUDIO_VM_AMR_PLAY_SESSION_ID)&&
             (p_audio_gbl_var->audio_vm_amr_play.state != AUDIO_IDLE))
        {
          return (AUDIO_VM_AMR_PLAY);
        }

        if ( (session_id == AUDIO_VM_AMR_RECORD_SESSION_ID)&&
             (p_audio_gbl_var->audio_vm_amr_record.state != AUDIO_IDLE))
        {
          return (AUDIO_VM_AMR_RECORD);
        }

        return(AUDIO_VM_AMR_NONE);
      }
      break;

      default:
        return(AUDIO_VM_AMR_NONE);
      break;
    } /* switch */
  }
#endif // #if (AUDIO_MEM_MANAGER)

#endif /* L1_VOICE_MEMO_AMR */
#endif /* RVM_AUDIO_MAIN_SWE */